87683[BUGFIX] Use correct log level in TypoScriptParser
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 810
-
Georg Ringer uploaded patch set 1 01/09/25, 19:52
-
Georg Ringer commented on patch set 1 01/09/25, 19:52
This change is ready for review. -
core-ci voted on patch set 1 V +1 01/09/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72168
-
Garvin Hicking updated the commit message in patch set 2
V +101/09/25, 20:23 -
Garvin Hicking voted on patch set 2 CR +1 V +1 01/09/25, 20:23
-
core-ci voted on patch set 2 V +1 01/09/25, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72169
-
Andreas Kienast commented on patch set 2 01/10/25, 07:45
TypoScriptParser.php:275I think it makes sense to remove `int|` from the type annotation of `error()` as well. -
Christian Kuhn commented on patch set 2 CR +1 V +1 01/13/25, 17:48
TypoScriptParser.php:275ReplyI agree this would be more correct. Considering TypoScriptParser is legacy in v12 and removed since v13, I'd argue adapting this does not make much of a difference, though. I'd go with the proposed solution only if that is fine with you. -
Christian Kuhn commented on patch set 2 CR +2 V +2 01/13/25, 18:55
got "ack" from Andreas and will merge now. -
Christian Kuhn merged patch set 3 01/13/25, 18:55