Review main Abandoned

87692[BUGFIX] Render correct icon for validated record

Philipp Kitzberger CR 0 V 0 Easy +5 −3 updated 02/11/25, 09:56

Commit message

This makes sure the correct parameters are being used for rendering the
icon of the validator record:

- uid (of target record)
- type field (doktype, CType)
- disable field (disable, hidden)

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Philipp Kitzberger uploaded patch set 1 01/10/25, 12:42

  2. core-ci voted on patch set 1 V +1 01/10/25, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72208

  3. Jasmina Ließmann commented on patch set 1 01/20/25, 15:56

    Unresolved

    In the course of https://forge.typo3.org/issues/104323, problems were identified with the output of icons of linked and now deleted records. Unfortunately, I can no longer name the exact scenario (it may also have been about records that were deleted in the workspace, because in the link validator module, changes made in the workspace are unfortunately(?) also displayed in the report table even though you are not in the workspace). Therefore, a workaround was added in the fluid of the report table and the standard icon of the respective record type is output as a fallback. I have just tested again with different content element types and link types, but was unable to create a scenario in which the standard icon is always output (as in the first image of the Forge ticket). Could you please describe your setup in more detail?
  4. Georg Ringer voted on patch set 1 CR +1 V +1 01/20/25, 19:16

  5. Georg Ringer commented on patch set 1 02/10/25, 20:10

    fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/88088, can you please retest @typo3@kitze.net
  6. Georg Ringer abandoned the change 02/11/25, 09:56

    confirmed, fixed now