Review main Merged

87695[TASK] Decouple dropdown styling

Benjamin Kott CR +2 V +2 Hard +687 −288 updated 01/17/25, 07:05

Commit message

We are dropping the Bootstrap CSS definitions for
all dropdowns to have more control about the
styling. From now on we are shipping custom css
adapted to our needs. We are keeping the classnames
to be fully compatible with Bootstrap for now to
avoid beeing breaking.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1930

Show 35 earlier messages
  1. Benjamin Kott uploaded patch set 1 01/10/25, 13:35

  2. core-ci voted on patch set 1 V +1 01/10/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72215

  3. Benjamin Kott uploaded patch set 2 V +1 01/13/25, 15:43

  4. core-ci voted on patch set 2 V +1 01/13/25, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72363

  5. Benjamin Kott uploaded patch set 3 V +1 01/14/25, 08:07

  1. Benjamin Kott rebased onto patch set 4 01/14/25, 08:10

  2. core-ci voted on patch set 3 V +1 01/14/25, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72397

  3. Benjamin Kott rebased onto patch set 5 01/14/25, 08:18

  4. core-ci voted on patch set 4 V +1 01/14/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72399

  5. core-ci voted on patch set 5 V +1 01/14/25, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72400

  6. Benjamin Kott rebased onto patch set 6 V +1 01/14/25, 08:31

  7. core-ci voted on patch set 6 V +1 01/14/25, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72403

  8. Benjamin Kott uploaded patch set 7 V +1 01/14/25, 08:43

  9. Benjamin Kott uploaded patch set 8 01/14/25, 08:47

  10. core-ci voted on patch set 7 V +1 01/14/25, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72406

  11. core-ci voted on patch set 8 V +1 01/14/25, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72407

  12. Benjamin Kott uploaded patch set 9 V +1 01/14/25, 08:55

  13. core-ci voted on patch set 9 V +1 01/14/25, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72409

  14. Benjamin Kott rebased onto patch set 10 V +1 01/14/25, 16:20

  15. core-ci voted on patch set 10 V +1 01/14/25, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72469

  16. Andreas Kienast commented on patch set 10 01/15/25, 07:31

    ShortcutToolbarItemDropDown.html:1

    If an extensions provides an own toolbar item, are these migration mandatory? If so, I'd consider this a breaking change.
  17. Benjamin Kott commented on patch set 10 01/15/25, 08:32

    ShortcutToolbarItemDropDown.html:1 Reply

    its not considered breaking, it will still behave as before and set the font size as this is not part of the rework.
  18. Andreas Kienast voted on patch set 10 CR +1 V +1 01/15/25, 08:35

  19. Benjamin Kott rebased onto patch set 11 CR +1 V +1 01/15/25, 14:18

  20. core-ci voted on patch set 11 V +1 01/15/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72528

  21. Andreas Kienast voted on patch set 11 CR +1 V +1 01/15/25, 14:54

  22. Benni Mack voted on patch set 11 CR +1 01/16/25, 09:09

  23. Benni Mack voted on patch set 11 V +1 01/16/25, 15:16

  24. Benjamin Kott voted on patch set 11 CR +2 V +2 01/17/25, 06:29

  25. Benjamin Kott merged patch set 12 01/17/25, 07:05