Review main Merged

87697[TASK] Switch to `selenium/standalone-chromium`

Andreas Kienast CR +2 V +2 Easy +10 −8 updated 03/05/25, 14:00

Commit message

Replace the CI image `selenium/standalone-chrome` with
`selenium/standalone-chromium`, which works on multiple platforms.
This makes the architecture check for arm64 obsolete.

Due to a window size related bug in the new headless mode in
chromium v128, we're pinning to chromium v131 (chromium v132 drops the
old headless mode). We'll try to upgrade to newer version once the
related chromium bug is resolved:
https://issues.chromium.org/issues/362522328

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1424

  1. Andreas Kienast uploaded patch set 1 01/10/25, 15:44

  2. Andreas Kienast uploaded patch set 2 01/10/25, 15:47

  3. core-ci voted on patch set 2 V -1 01/10/25, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72222

  4. core-ci voted on patch set 1 V -1 01/10/25, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72221

  5. core-ci voted on patch set 1 V -1 01/10/25, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72221

  6. core-ci commented on patch set 2 01/10/25, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72222

  7. Andreas Kienast marked it work in progress 01/13/25, 11:30

  8. Andreas Kienast uploaded patch set 3 V -1 01/13/25, 14:46

  9. core-ci voted on patch set 3 V +1 01/13/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72359

  10. Benjamin Franzke rebased onto patch set 4 V +1 03/05/25, 11:04

  11. Benjamin Franzke commented on patch set 4 03/05/25, 11:04

    codeception.yml:26

    Could not find a reason why this is needed (tested with both locally). trying to reset this to patchset 2 state…
  12. Benjamin Franzke uploaded patch set 5 03/05/25, 11:05

  13. core-ci voted on patch set 4 V +1 03/05/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75154

  14. core-ci voted on patch set 5 V -1 03/05/25, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75155

  15. Benjamin Franzke uploaded patch set 6 V -1 03/05/25, 12:42

  16. Benjamin Franzke commented on patch set 6 03/05/25, 12:42

    codeception.yml:26 Reply

    Caused by https://issues.chromium.org/issues/40275252, added a workaround to use `headless=old` for now
  17. core-ci voted on patch set 6 V +1 03/05/25, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75165

  18. core-ci commented on patch set 6 03/05/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75168

  19. Benjamin Franzke updated the commit message in patch set 7 CR +1 V +1 03/05/25, 13:12

  20. Christian Kuhn commented on patch set 7 CR +1 V +1 03/05/25, 13:19

    i'll +1 since main-nightly seems to be good on this one. it would be cool if the backports could run a nightly as well.
  21. core-ci voted on patch set 7 V +1 03/05/25, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75174

  22. Benjamin Franzke commented on patch set 7 03/05/25, 13:22

    Reply

    ack, will do
  23. Benjamin Franzke voted on patch set 7 CR +2 V +2 03/05/25, 14:00

  24. Benjamin Franzke merged patch set 8 03/05/25, 14:00