Review main Merged

87702[TASK] Remove two unused methods in DataHandler

Daniel Windloff CR +2 V +2 Easy +0 −35 updated 01/13/25, 10:48

Commit message

The patch removes two unused and `@internal` marked methods
in DataHandler:

* `DataHandler->deleteClause`
* `DataHandler->checkValue_inline`

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2027

Show 12 earlier messages
  1. Daniel Windloff uploaded patch set 1 01/11/25, 12:03

  2. core-ci voted on patch set 1 V +1 01/11/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72243

  1. Andreas Kienast updated the commit message in patch set 2 V +1 01/11/25, 13:24

  2. core-ci voted on patch set 2 V +1 01/11/25, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72244

  3. Garvin Hicking wrote 01/11/25, 18:40

    Topic set to Datahandler
  4. Garvin Hicking commented on patch set 3 V +1 01/11/25, 18:47

    Published edit on patch set 2.
  5. core-ci voted on patch set 3 V +1 01/11/25, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72245

  6. Chris Müller commented on patch set 4 V +1 01/11/25, 19:13

    Published edit on patch set 3.
  7. Chris Müller commented on patch set 5 01/11/25, 19:13

    Published edit on patch set 4.
  8. core-ci voted on patch set 4 V +1 01/11/25, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72246

  9. core-ci voted on patch set 5 V +1 01/11/25, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72247

  10. Georg Ringer commented on patch set 5 CR -1 01/11/25, 20:53

    Breaking-105917-DHRemoveUnusedMethodsDeleteClauseAndCheckValue_inline.rst:6

    never seen the abbr. DH for datahandler. I suggest "Remove unused methods from DataHandler" as alternative. no need to have the method names in the title (or leave it there, don't mind tbh) but DH needs to be replaced
  11. Daniel Windloff uploaded patch set 6 CR -1 V +1 01/12/25, 07:50

  12. Daniel Windloff commented on patch set 6 01/12/25, 07:52

    Breaking-105917-DHRemoveUnusedMethodsDeleteClauseAndCheckValue_inline.rst:6 Reply

    Done
  13. core-ci voted on patch set 6 V +1 01/12/25, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72266

  14. Georg Ringer voted on patch set 6 CR +1 V +1 01/12/25, 21:26

  15. Benni Mack commented on patch set 6 01/13/25, 08:27

    The methods are internal, why is this a breaking change?
  16. Daniel Windloff commented on patch set 6 01/13/25, 08:41

    Reply

    Initially, I don't mark the change as breaking in the commit message as the methods are internal. I add a breaking rst (which fits best from my point of view) for documentation, as I would like to have an extension scanner in place.
  17. Oli Bartsch commented on patch set 6 01/13/25, 09:12

    Reply

    Why do you want to have this documented? Is there a specific reason. As @benni@typo3.org already mentioned, those methods are internal and do not need a breaking.rst / extension scanner entry. Do you think that the methods might have been heavily used in 3rd party, unless marked as internal? If so, we might want to add a Important.rst but IMO no breaking.rst.
  18. Daniel Windloff commented on patch set 6 01/13/25, 09:48

    Reply

    Mainly because these methods at least nine years old, but I could remove the rst file.
  19. Christian Kuhn uploaded patch set 7 CR +1 V +1 01/13/25, 09:55

  20. Christian Kuhn commented on patch set 7 CR +1 V +1 01/13/25, 10:01

    Reply

    Thx Daniel. I did just that. I think we shouldn't start documenting the internal to not set a precedent here - we may then end up having such a discussion with all cases. Also, consumers within extensions don't seem to be very likely: a TER search found nothing for checkValue_inline() and matches to deleteClause() were bound to the identically named method in BackendUtility. It looks to me as if the impact of this removal is small in extensions. I shortened the patch accordingly and will vote up now, hope that is fine with you.
  21. Oli Bartsch commented on patch set 7 CR +1 V +1 01/13/25, 10:02

    ^
  22. core-ci voted on patch set 7 V +1 01/13/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72299

  23. Stefan Bürk voted on patch set 7 CR +1 V +1 01/13/25, 10:47

  24. Stefan Bürk voted on patch set 7 CR +2 V +2 01/13/25, 10:48

  25. Stefan Bürk merged patch set 8 01/13/25, 10:48