Review main Abandoned Breaking

87703[!!!][TASK] Fallback for defaultMailFromAddress removed

Sven Liebert CR 0 V 0 Normal +142 −14 updated 03/11/25, 18:58

Commit message

A missing $GLOBALS['TYPO3_CONF_VARS']['MAIL']['defaultMailFromAddress']
configuration now throws an exception instead of falling back to a
default mail address.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 12

Review log 2027

Show 12 earlier messages
  1. Sven Liebert uploaded patch set 1 01/11/25, 20:28

  2. core-ci voted on patch set 1 V -1 01/11/25, 20:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72248

  1. Sven Liebert uploaded patch set 2 V -1 01/11/25, 20:50

  2. core-ci voted on patch set 2 V -1 01/11/25, 20:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72249

  3. Sven Liebert uploaded patch set 3 V -1 01/11/25, 21:10

  4. core-ci voted on patch set 3 V -1 01/11/25, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72250

  5. Sven Liebert uploaded patch set 4 V -1 01/11/25, 21:19

  6. core-ci voted on patch set 4 V +1 01/11/25, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72251

  7. Garvin Hicking wrote 01/13/25, 06:09

    Topic set to Mail
  8. Chris Müller commented on patch set 5 V +1 01/13/25, 08:11

    Published edit on patch set 4.
  9. core-ci voted on patch set 5 V +1 01/13/25, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72289

  10. Benni Mack commented on patch set 5 01/13/25, 08:26

    Hey Sven, should we rather have a EXT:report entry to show that the configuration is not optimal?
  11. Christian Kuhn commented on patch set 5 01/13/25, 11:03

    Reply

    I tend to agree, an ext:report check is probably a better approach: Throwing an exception when no from-address is configured makes this setting pretty much mandatory as soon as an instance sends a mail. This can lead to headaches on non-production systems where a proper from-address may not be important when mails are for instance delivered to a mailhog instance.
  12. Stefan Bürk commented on patch set 5 01/13/25, 11:15

    Reply

    I have kind of a splitted view here. On the one hand this would reveal issues before deployments special for newcommers which does not have it in the blood to verify system setup using the reports module and having a hard exception may be more helpfull here. On the otherhand it may really be disturbing and reveals this issue to the outside. In the end I'm here also for having it in the ext:reports module now and additional as note/information in the install tool test mail setup. Mid-term we could also think about adding mailsetup (optional) to the install step wizard + setup command to lead developer/integrator on project setup to set this directly to some valid values. The default "from" is a very often missed configuration in mailsetups and an oversight.
  13. Sven Liebert commented on patch set 5 01/13/25, 11:18

    Reply

    Yes that is a good idea. I will add this! I see this like Stefan, because you should see the issue on a non-production environment before!
  14. Sven Liebert uploaded patch set 6 V +1 01/16/25, 17:55

  15. core-ci voted on patch set 6 V +1 01/16/25, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72573

  16. Sven Liebert commented on patch set 6 01/16/25, 18:03

    Reply Unresolved

    @benni@typo3.org i added the entry in EXT:report. Please review again.
  17. Simon Schaufelberger commented on patch set 6 CR -1 01/17/25, 15:42

    ConfigurationStatus.php:358

    opened ul but closing ol.
  18. Simon Schaufelberger commented on patch set 6 01/17/25, 15:43

    ConfigurationStatus.php:356

    add return type
  19. Sven Liebert uploaded patch set 7 CR -1 V +1 01/18/25, 09:09

  20. Sven Liebert commented on patch set 7 01/18/25, 09:10

    ConfigurationStatus.php:356 Reply

    Done

    ConfigurationStatus.php:358 Reply

    Done
  21. core-ci voted on patch set 7 V +1 01/18/25, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72657

  22. Simon Schaufelberger voted on patch set 7 CR +1 V +1 01/18/25, 15:14

  23. Sven Liebert abandoned the change 03/11/25, 17:37

  24. Simon Schaufelberger commented on patch set 7 03/11/25, 18:50

    why abandoned?
  25. Sven Liebert commented on patch set 7 03/11/25, 18:58

    Reply Unresolved

    It should be only the report entry and not an exception according to Benni‘s comment. I will upload a new patch later.