Review 13.4 Merged

87708[TASK] Require a template filename in extbase module template rendering

Stefan Bürk CR +2 V +2 Normal +65 −0 updated 01/13/25, 10:59

Commit message

Previously, the module template methods `renderResponse()` and
`render()` could be called without providing a `$templateFileName`
in extbase backend modules. If no `$templateFileName` was provided,
the template was automatically resolved from the current extbase
controller name and action name.

With the introduction of FluidAdapter in TYPO3 v13, the dependencies
between fluid and extbase have been decoupled. It has however been
forgotten to implement and document, that a `$templateFileName` must
be provided for render-methods in `ModuleTemplate`.

With this change, render-methods in `ModuleTemplate` now throw an
`InvalidArgumentException`, when the `$templateFileName` argument
is an empty string.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 01/13/25, 10:49

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/13/25, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72310

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 01/13/25, 10:59

  4. Stefan Bürk merged patch set 2 01/13/25, 10:59