Review 13.4 Merged

87717[TASK] Isolate functional test fixture assets for EXT:frontend

Stefan Bürk CR +2 V +2 Easy +6 −5 updated 01/13/25, 13:39

Commit message

This patch removes fixture cross-dependencies from EXT:frontend to
EXT:core. The existing "pages_frontend.csv" file is identical to
the Core's "pages.csv" Fixture and can be switched. A very simple
Fluid Partial (one liner) is copied to be distinct to EXT:frontend.

Assets are copied to be unique and prevent side-effects when
files are changed at their original location. Tests should be
side-effect free and isolated.

Remaining exemption for cross-dependencies are references to:

EXT:core/Tests/Functional/Fixtures/Frontend/JsonRenderer.typoscript
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_csv
EXT:core/Tests/Functional/Fixtures/Extensions/test_eid
EXT:core/Tests/Functional/Fixtures/Extensions/test_classic_content
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mm
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mnsymmetric
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributesimple

These central fixtures should not be redundantly stored,
and are fittingly placed in the "EXT:core" space.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 4

Files 5

Review log 34

  1. Stefan Bürk commented on patch set 1 01/13/25, 13:31

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/13/25, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72347

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 01/13/25, 13:39

  4. Stefan Bürk merged patch set 2 01/13/25, 13:39