Review main Merged

87722[BUGFIX] Use field labels in record download for processed values

Oli Bartsch CR +2 V +2 Easy +24 −1 updated 01/20/25, 08:49

Commit message

In case processed values are used in the download of records
in the backend record list (only for CSV format), the field labels
are now displayed with their corresponding backend label.

This allows to use proper column labelling for special fields like
"hidden", which gets labelled as "Enabled" by default and
contains processed values "Yes" and "No". Without this bugfix,
such labels would show a row like "Enabled=Yes" for a "hidden=1"
field, confusing its meaning.

This does not apply to the "raw" download with unprocessed
values, which retain the raw column names. The JSON format
also retains the actual column names.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1520

  1. Oli Bartsch uploaded patch set 1 01/13/25, 21:57

  2. core-ci voted on patch set 1 V +1 01/13/25, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72379

  3. Garvin Hicking wrote 01/14/25, 06:09

    Topic set to recordlist
  4. Garvin Hicking updated the commit message in patch set 2 V +1 01/14/25, 06:12

  5. core-ci voted on patch set 2 V +1 01/14/25, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72395

  6. Garvin Hicking updated the commit message in patch set 3 V +1 01/14/25, 07:55

  7. Garvin Hicking voted on patch set 3 CR +1 V +1 01/14/25, 07:55

  8. core-ci voted on patch set 3 V +1 01/14/25, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72396

  9. Oli Bartsch uploaded patch set 4 CR +1 V +1 01/14/25, 08:08

  10. Garvin Hicking voted on patch set 4 CR +1 V +1 01/14/25, 08:11

  11. core-ci voted on patch set 4 V +1 01/14/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72398

  12. Stefan Bürk commented on patch set 4 01/14/25, 22:58

    RecordListDownloadController.php:163

    Why using $label and not assigning to $headerField directly ? Same for the elsif branch which would make the 3rd else branch obsolete .... Kind of confusing the forth and back between the variables here.
  13. Oli Bartsch commented on patch set 4 01/15/25, 07:20

    RecordListDownloadController.php:163 Reply

    I do not understand this. IMO we can not overwrite $headerField at the beginning as it is used in the translateLabel() method to check for tsConfig for this field name. However, I may have missed something and would be more than happy if you could simplify the patch.
  14. Oli Bartsch uploaded patch set 5 CR +1 V +1 01/18/25, 12:34

  15. Oli Bartsch commented on patch set 5 01/18/25, 12:35

    RecordListDownloadController.php:163 Reply

    Done
  16. core-ci voted on patch set 5 V +1 01/18/25, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72659

  17. Garvin Hicking voted on patch set 5 CR +1 V +1 01/18/25, 19:03

  18. Stefan Bürk voted on patch set 5 CR +1 V +1 01/19/25, 17:54

  19. Oli Bartsch voted on patch set 5 CR +2 V +2 01/20/25, 08:49

  20. Oli Bartsch merged patch set 6 01/20/25, 08:49