Review main Merged

87733[TASK] Refine styling of color-scheme toggle button

Benjamin Kott CR +2 V +2 Easy +5 −6 updated 01/14/25, 10:43

Commit message

The button is now always displayed with a default button
styling and no longer uses a primary styling in dark mode.

The original intention was to toggle light and dark mode.
An active state would have been fine if we did not change
the label and it simply stated "enable/disable." However,
we are showing the currently selected value here. For this
reason, the primary state is invalid and behaves inconsistently
with other elements in the backend.

To better indicate that we are switching a state here,
another icon has been added to the button. This icon
helps to represent the triggered action alongside the
currently active mode.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benjamin Kott uploaded patch set 1 01/14/25, 08:31

  2. core-ci voted on patch set 1 V +1 01/14/25, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72404

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 01/14/25, 09:11

  4. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/14/25, 09:28

  5. Benjamin Franzke merged patch set 2 01/14/25, 10:43