Review main Merged

87745[BUGFIX] Correct no entries element nesting for variable picker

Benjamin Kott CR +2 V +2 Easy +3 −3 updated 01/14/25, 11:43

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Benjamin Kott uploaded patch set 1 01/14/25, 09:48

  2. Benjamin Franzke commented on patch set 1 01/14/25, 10:04

    inspector-component.ts:2431

    This fixes the technical issue that the icon and label were misplaced, but this button still implies that something can be done – while it only closes the dropdown. maybe we can only add a `<span>`?
  3. core-ci voted on patch set 1 V +1 01/14/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72426

  4. Benjamin Kott rebased onto patch set 2 V +1 01/14/25, 10:38

  5. Benjamin Kott uploaded patch set 3 01/14/25, 10:40

  6. Benjamin Kott commented on patch set 3 01/14/25, 10:40

    inspector-component.ts:2431 Reply

    Done
  7. Benjamin Franzke voted on patch set 3 CR +1 V +1 01/14/25, 10:45

  8. core-ci voted on patch set 2 V +1 01/14/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72438

  9. core-ci voted on patch set 3 V +1 01/14/25, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72439

  10. Andreas Kienast voted on patch set 3 CR +1 V +1 01/14/25, 11:02

  11. Benjamin Franzke voted on patch set 3 CR +2 V +2 01/14/25, 11:21

  12. Benjamin Franzke merged patch set 4 01/14/25, 11:43