87752[BUGFIX] Fix behavior and styling of EXT:form element type listing
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 6
- Build/Sources/Sass/component/_buttons.scss+11 −0
- Build/Sources/TypeScript/form/backend/form-editor/modals-component.ts2+2 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −0
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertElements.html2+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertPages.html2+3 −6
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/modals-component.js+1 −1
Review log 2023
-
Benjamin Kott uploaded patch set 1 01/14/25, 10:36
-
core-ci voted on patch set 1 V +1 01/14/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72437
-
Benjamin Franzke commented on patch set 1 CR -2 01/14/25, 11:03
It's important to mention behavior first. -
Benjamin Franzke commented on patch set 1 01/14/25, 11:03
I'd love to see the `<buttons>` component -
Benjamin Kott commented on patch set 1 01/14/25, 11:07
Reply
🖕 -
Benjamin Franzke uploaded patch set 2
V +101/14/25, 11:09Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Franzke commented on patch set 2 01/14/25, 11:09
Reply
❤️ -
core-ci voted on patch set 2 V +1 01/14/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72449
-
Benjamin Kott commented on patch set 2 01/14/25, 11:26
@ben@bnf.dev 🖕 -
Benjamin Franzke commented on patch set 2 01/14/25, 11:27
Reply
❤️❤️❤️ -
Andreas Kienast voted on patch set 2 CR +1 V +1 01/14/25, 11:52
-
Ayke Halder commented on patch set 2 01/14/25, 12:51
modals-component.ts:202How about using a more specific `button[data-element-type]` selector? Or as an alternative implement a new class-attribute like `t3js-form-insert-element`. -
Ayke Halder commented on patch set 2 CR -1 01/14/25, 13:39
There is an old change which migrates away from `btn-block` and implements `d-grid` on the parent element instead. 75098: [BUGFIX] Replace usage of btn-block | https://review.typo3.org/c/Packages/TYPO3.CMS/+/75098InsertElements.html:11Maybe use `d-grid` on parent `div` instead of `btn-block` on button itself.InsertPages.html:11Also here: Maybe use `d-grid` on parent `div` instead of `btn-block` on button itself. -
Garvin Hicking updated the commit message in patch set 3
CR +1V +101/14/25, 14:07 -
Andreas Kienast commented on patch set 3 01/14/25, 14:10
Reply
`.btn-block` was added when the styling of buttons has been made independent from Bootstrap, rendering the linked PR obsolete. -
core-ci voted on patch set 3 V +1 01/14/25, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72462
-
Benjamin Kott commented on patch set 3 01/14/25, 14:26
modals-component.ts:202Replythe whole module needs to undergo serious changes and a rewrite. for now, we only want to have it working again, not better nor worse than before - just working.InsertElements.html:11Replywe are not using d-grid or any other utility classes - we are removing bootstrap and those when we can. while it´s called btn-block. technically it's a btn-flex to ensure it moving from inline-flex to flex to keep it´s behavior. the name is different because we wanted to keep compat with bootstrap. all random utility classes will be removed in the long run.InsertPages.html:11Replysee other note -
Benjamin Franzke voted on patch set 3 CR +1 V +1 01/14/25, 14:30
-
Benni Mack commented on patch set 3 CR +1 V +1 01/16/25, 07:39
Thanks for fixing this one! -
Andreas Kienast voted on patch set 3 CR +1 V +1 01/16/25, 08:01
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 01/16/25, 09:05
-
Benjamin Franzke merged patch set 4 01/16/25, 09:05