Review main Merged

87752[BUGFIX] Fix behavior and styling of EXT:form element type listing

Benjamin Kott CR +2 V +2 Easy +20 −10 updated 01/16/25, 09:05

Commit message

With #104901, the migration from <a> to <button> the JavaScript
handlers were not updated to accommodate the new markup,
preventing proper insertion of elements into form creating with EXT:form.

Additionally, the styling was misaligned for elements and page types
in the form.

This patch restores the correct visual styling for the element list and
updates the JavaScript handlers to ensure compatibility with the new
button-based markup.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 2023

  1. Benjamin Kott uploaded patch set 1 01/14/25, 10:36

  2. core-ci voted on patch set 1 V +1 01/14/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72437

  3. Benjamin Franzke commented on patch set 1 CR -2 01/14/25, 11:03

    It's important to mention behavior first.
  4. Benjamin Franzke commented on patch set 1 01/14/25, 11:03

    I'd love to see the `<buttons>` component
  5. Benjamin Kott commented on patch set 1 01/14/25, 11:07

    Reply

    🖕
  6. Benjamin Franzke uploaded patch set 2 V +1 01/14/25, 11:09

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  7. Benjamin Franzke commented on patch set 2 01/14/25, 11:09

    Reply

    Done

    Reply

    Done
  8. Benjamin Franzke commented on patch set 2 01/14/25, 11:09

    Reply

    ❤️
  9. core-ci voted on patch set 2 V +1 01/14/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72449

  10. Benjamin Kott commented on patch set 2 01/14/25, 11:26

    @ben@bnf.dev 🖕
  11. Benjamin Franzke commented on patch set 2 01/14/25, 11:27

    Reply

    ❤️❤️❤️
  12. Andreas Kienast voted on patch set 2 CR +1 V +1 01/14/25, 11:52

  13. Ayke Halder commented on patch set 2 01/14/25, 12:51

    modals-component.ts:202

    How about using a more specific `button[data-element-type]` selector? Or as an alternative implement a new class-attribute like `t3js-form-insert-element`.
  14. Ayke Halder commented on patch set 2 CR -1 01/14/25, 13:39

    There is an old change which migrates away from `btn-block` and implements `d-grid` on the parent element instead. 75098: [BUGFIX] Replace usage of btn-block | https://review.typo3.org/c/Packages/TYPO3.CMS/+/75098

    InsertElements.html:11

    Maybe use `d-grid` on parent `div` instead of `btn-block` on button itself.

    InsertPages.html:11

    Also here: Maybe use `d-grid` on parent `div` instead of `btn-block` on button itself.
  15. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 01/14/25, 14:07

  16. Andreas Kienast commented on patch set 3 01/14/25, 14:10

    Reply

    `.btn-block` was added when the styling of buttons has been made independent from Bootstrap, rendering the linked PR obsolete.
  17. core-ci voted on patch set 3 V +1 01/14/25, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72462

  18. Benjamin Kott commented on patch set 3 01/14/25, 14:26

    modals-component.ts:202 Reply

    the whole module needs to undergo serious changes and a rewrite. for now, we only want to have it working again, not better nor worse than before - just working.

    InsertElements.html:11 Reply

    we are not using d-grid or any other utility classes - we are removing bootstrap and those when we can. while it´s called btn-block. technically it's a btn-flex to ensure it moving from inline-flex to flex to keep it´s behavior. the name is different because we wanted to keep compat with bootstrap. all random utility classes will be removed in the long run.

    InsertPages.html:11 Reply

    see other note
  19. Benjamin Franzke voted on patch set 3 CR +1 V +1 01/14/25, 14:30

  20. Benni Mack commented on patch set 3 CR +1 V +1 01/16/25, 07:39

    Thanks for fixing this one!
  21. Andreas Kienast voted on patch set 3 CR +1 V +1 01/16/25, 08:01

  22. Benjamin Franzke voted on patch set 3 CR +2 V +2 01/16/25, 09:05

  23. Benjamin Franzke merged patch set 4 01/16/25, 09:05