87757[BUGFIX] Respect column `CHARACTER SET` AND `COLLATE` in ext_tables.sql
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 8
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php+45 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+13 −0
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php2+14 −3
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-106508-RespectColumnCharacterSetAndCollationInExt_tablessql.rstnew+55 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/newTableWithAsciiBasedCharsetAndCollate.sqlnew+17 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/newTableWithLatin1BasedCharsetAndCollate.sqlnew+17 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+160 −0
- typo3/sysext/core/ext_tables.sql2+1 −2
Review log 2233
Show 48 earlier messages
-
Stefan Bürk uploaded patch set 1 01/14/25, 12:35
-
core-ci voted on patch set 1 V +1 01/14/25, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72459
-
Stefan Bürk uploaded patch set 2
V +101/17/25, 14:37 -
core-ci voted on patch set 2 V +1 01/17/25, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72619
-
Stefan Bürk uploaded patch set 3
V +104/03/25, 09:49 -
core-ci voted on patch set 3 V +1 04/03/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76933
-
Stefan Bürk uploaded patch set 4
V +104/03/25, 10:18 -
core-ci voted on patch set 4 V +1 04/03/25, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76937
-
Stefan Bürk uploaded patch set 5
V +104/03/25, 15:28 -
core-ci voted on patch set 5 V +1 04/03/25, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76956
-
Stefan Bürk updated the commit message in patch set 6
V +104/03/25, 15:34 -
core-ci voted on patch set 6 V +1 04/03/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76957
-
Benjamin Franzke commented on patch set 6 CR -1 04/03/25, 18:34
-
Stefan Bürk uploaded patch set 7
CR -1V +104/04/25, 08:30 -
core-ci voted on patch set 7 V +1 04/04/25, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76990
-
Stefan Bürk voted on patch set 7 CR -1 04/04/25, 08:46
-
Stefan Bürk uploaded patch set 8
CR -1V +104/04/25, 14:20 -
Stefan Bürk updated the commit message in patch set 9 04/04/25, 14:22
-
Stefan Bürk commented on patch set 9 04/04/25, 14:24
ext_tables.sql:198ReplyI think you are absolutly right, thanks for the input. Changed it now to ascii/ascii bin now and tested the changes again. -
core-ci voted on patch set 8 V +1 04/04/25, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77008
-
core-ci voted on patch set 9 V +1 04/04/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77009
-
Benjamin Franzke commented on patch set 9 04/04/25, 15:34
ConnectionMigrator.php:1687will be set to BINARY in line 1693 for sqlite. This makes this hard to understand, as the comment says it's enforced, but actually it is not, since it is overwritten later. Maybe the logic for sqlite vs postgres should be split? -
Stefan Bürk uploaded patch set 10
V +104/04/25, 19:19 -
Stefan Bürk commented on patch set 10 04/04/25, 19:20
ConnectionMigrator.php:1687ReplyDone -
core-ci voted on patch set 10 V +1 04/04/25, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77015
-
Christian Kuhn uploaded patch set 11
V +104/07/25, 09:29 -
Christian Kuhn voted on patch set 11 CR +1 V +1 04/07/25, 09:30
-
core-ci voted on patch set 11 V +1 04/07/25, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77101
-
Benni Mack voted on patch set 11 CR +1 V +1 04/07/25, 10:14
-
Christian Kuhn voted on patch set 11 CR +2 V +2 04/07/25, 10:31
-
Christian Kuhn merged patch set 12 04/07/25, 10:48
-
Ayke Halder commented on patch set 12 04/07/25, 12:39
> For the start `CHARACTER SET ascii COLLATE ascii_bin` is used for table `sys_refindex` column `hash` to reduce required space for the index using a single byte instead of multiple bytes per character. This is possible since the hash field contains 'hex' ascii 0-9,a-f only. With MariaDB I do not get any improvement of db size when `hash` columns character-set is changed to `ascii_bin` instead of default `utf8mb4_unicode_ci`. Do a before/after comparison with these statistics: ```sql OPTIMIZE TABLE `sys_refindex`; SHOW TABLE STATUS FROM `db` WHERE `Name` = 'sys_refindex'; ``` -
Christian Kuhn commented on patch set 12 04/07/25, 14:28
Reply
compare something like this before/after: select database_name, index_name, (1.0stat_value@@innodb_page_size/1024/1024) as index_size, table_name from mysql.innodb_index_stats where stat_name = 'size' and index_name not in ('GEN_CLUST_INDEX') and database_name = 'coremaster' and table_name='sys_refindex' order by index_size desc;
ext_tables.sql:198