Review 12.4 Merged

87763[BUGFIX] Avoid $e->getPrevious() in DH->insertDB() exceptions

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 01/14/25, 17:39

Commit message

$e->getPrevious() on \Doctrine\DBAL\Exception may be null
depending on the specific doctrine exception being thrown.
Within DataHandler->insertDB(), we're interested in the fail
message from the driver if given. The exception handling
within doctrine has been improved with v3. The exception
message of \Doctrine\DBAL\Exception now always contains
the fail message from a driver if given, there is no
point in trying to fetch the message from a possible
previous exception anymore.
The patch streamlines DataHandler->insertDB() a bit and
logs the exception message from the "outer" exception
directly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/14/25, 17:25

  2. Christian Kuhn commented on patch set 1 01/14/25, 17:26

    @stefan@buerk.tech could you do a dedicated v12 review of this one? this is no a one-liner in v12 since a surrounding if() has been removed in v13, and i think this is the most non-intrusive way to solve the issue in v12?
  3. core-ci voted on patch set 1 V +1 01/14/25, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72472

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 01/14/25, 17:31

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 01/14/25, 17:39

  6. Christian Kuhn merged patch set 2 01/14/25, 17:39