87771[BUGFIX] Gracefully handle invalid punycode domains in URI parsing
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Oliver Hader +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1314
-
Benjamin Franzke uploaded patch set 1 01/15/25, 10:51
-
core-ci voted on patch set 1 V +1 01/15/25, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72513
-
Benjamin Franzke commented on patch set 1 01/15/25, 11:03
-
Andreas Kienast voted on patch set 1 CR +1 V +1 01/15/25, 11:08
-
Benjamin Franzke commented on patch set 1 01/15/25, 11:08
Uri.php:195ReplyRequires phpstan level 7 instead of 5. -
Oliver Hader voted on patch set 1 CR +1 01/15/25, 11:36
-
Oliver Hader commented on patch set 1 CR 0 01/15/25, 11:45
UriTest.php:607I did not find a test-case checking for e.g. `new Uri('https://tüpö3.org')`... -
Benjamin Franzke commented on patch set 1 01/15/25, 12:01
UriTest.php:607ReplyLine 516, added with: > 87049: [TASK] Increase Uri test coverage | https://review.typo3.org/c/Packages/TYPO3.CMS/+/87049 -
Oliver Hader commented on patch set 1 01/16/25, 13:01
UriTest.php:607ReplyAcknowledged -
Oliver Hader voted on patch set 1 CR +1 01/16/25, 13:01
-
Oliver Hader voted on patch set 1 V +1 01/16/25, 14:48
-
Benni Mack voted on patch set 1 CR +1 V +1 01/16/25, 15:00
-
Benjamin Franzke voted on patch set 1 CR +2 V +2 01/16/25, 16:07
-
Benjamin Franzke merged patch set 2 01/17/25, 07:54
Uri.php:195