Review main Merged

87773[TASK] Add more required file reference examples to EXT:styleguide

Garvin Hicking CR +2 V +2 Normal +147 −1 updated 01/18/25, 08:45

Commit message

This adds more examples:

- file_2: Exactly 1 file (not more)
- file_3: At least 2 files, maximum 4
- inline_file_1: IRRE file relations, again with file_1, file_2, file_3

The test are added to reproduce issue #105938.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Garvin Hicking uploaded patch set 1 01/15/25, 12:29

  2. core-ci voted on patch set 1 V +1 01/15/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72517

  3. Anja Leichsenring commented on patch set 1 01/16/25, 05:25

    okay in itself, but the styleguide generator does not respect the min- or max amounts and therefor produces invalid values. This needs adjustment before merge.
  4. Garvin Hicking commented on patch set 1 01/16/25, 09:36

    Reply

    Thank you! Made a pre-patch for this: 87778: [BUGFIX] Add missing minitems/maxitems EXT:styleguide generators | https://review.typo3.org/c/Packages/TYPO3.CMS/+/87778
  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 01/17/25, 20:47

  6. Georg Ringer voted on patch set 1 CR +1 V +1 01/18/25, 05:28

  7. Garvin Hicking voted on patch set 1 CR +2 V +2 01/18/25, 08:38

  8. Garvin Hicking merged patch set 2 01/18/25, 08:45