Review main Merged

87774[TASK] Obtain DH in ClearPageCacheController when needed

Christian Kuhn CR +2 V +2 Easy +4 −16 updated 01/16/25, 10:40

Commit message

Not creating the stateful DataHandler in __construct()
but doing it on demand makes the controller stateless.
This avoids the risk of re-using the same instance if
the controller is refactored since DataHandler needs
to be considered "tainted" after use.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 01/15/25, 13:39

  2. core-ci voted on patch set 1 V +1 01/15/25, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72523

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 01/15/25, 13:48

  4. Garvin Hicking voted on patch set 1 CR +1 01/15/25, 13:48

  5. Oliver Hader voted on patch set 1 CR +1 01/15/25, 14:41

  6. Garvin Hicking voted on patch set 1 V +1 01/15/25, 21:30

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 01/16/25, 10:40

  8. Christian Kuhn merged patch set 2 01/16/25, 10:40