Review 13.4 Merged

87776[BUGFIX] Fix missing FormEngine file upload controls for maxitems=X

Oli Bartsch CR +2 V +2 Easy +4 −2 updated 01/16/25, 09:07

Commit message

Unlike the IRRE inline container, the file upload container uses
a webcomponent, thus the CSS selector with ':scope >' is not
applicable.

Because the selector did not match, the file controls could not
be re-enabled once it was hidden due to a max/minitems configuration.
Also, the form could not be saved because a file would then be
missing.

IRRE childs with max/minitems were not affected.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 01/16/25, 08:22

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/16/25, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72549

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 01/16/25, 09:07

  4. Oli Bartsch merged patch set 2 01/16/25, 09:07