87779[BUGFIX] Scroll the main document instead of .module
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 19
- Build/Sources/Sass/component/_elementbrowser.scss+5 −6
- Build/Sources/Sass/component/_module.scss+8 −8
- Build/Sources/Sass/component/_root.scss+4 −1
- Build/Sources/Sass/scaffold/_scaffold.scss2+8 −21
- Build/Sources/Sass/form.scss+1 −3
- Build/Sources/TypeScript/backend/module/iframe.ts+0 −1
- Build/Sources/TypeScript/backend/date-time-picker.ts+0 −49
- Build/Sources/TypeScript/backend/document-header.ts+3 −9
- Build/Sources/TypeScript/backend/modal.ts+0 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+16 −16
- typo3/sysext/backend/Resources/Public/JavaScript/module/iframe.js+0 −1
- typo3/sysext/backend/Resources/Public/JavaScript/date-time-picker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/document-header.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsGroupCest.php+0 −10
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/SysNoteCest.php+0 −2
- typo3/sysext/core/Tests/Acceptance/Application/Site/SiteModuleCest.php+3 −0
- typo3/sysext/core/Tests/codeception.yml+4 −1
- typo3/sysext/form/Resources/Public/Css/form.css+1 −1
Review log 2547
Show 1322 earlier messages
-
Benjamin Franzke uploaded patch set 1 01/16/25, 11:27
-
Benjamin Franzke uploaded patch set 2 01/16/25, 11:28
-
core-ci voted on patch set 1 V -1 01/16/25, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72556
-
core-ci voted on patch set 2 V -1 01/16/25, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72557
-
Benjamin Franzke uploaded patch set 3
V -101/16/25, 13:04 -
core-ci voted on patch set 3 V -1 01/16/25, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72558
-
Benjamin Franzke uploaded patch set 4
V -101/17/25, 08:33 -
Benjamin Franzke uploaded patch set 5 01/17/25, 08:33
-
core-ci voted on patch set 5 V -1 01/17/25, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72603
-
Benjamin Franzke uploaded patch set 6
V -101/17/25, 09:03 -
core-ci voted on patch set 6 V -1 01/17/25, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72605
-
Benjamin Franzke uploaded patch set 7
V -101/17/25, 09:23 -
core-ci voted on patch set 7 V -1 01/17/25, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72607
-
Benjamin Franzke uploaded patch set 8
V -101/17/25, 09:36 -
core-ci voted on patch set 8 V +1 01/17/25, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72609
-
Benjamin Franzke uploaded patch set 9
V +101/17/25, 09:56 -
core-ci voted on patch set 9 V +1 01/17/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72611
-
Andreas Kienast commented on patch set 9 01/17/25, 10:34
-
Benjamin Franzke uploaded patch set 10
V +101/17/25, 13:09 -
Benjamin Franzke commented on patch set 10 01/17/25, 13:09
_scaffold.scss:35Replythx for noticing. 100% is actually fine here (acts like 100dvh), but 100vh used below became now became inaccurate, now that the root is scrollable, as 100vh now includes the (possibly hiding) scrollbar, therefore we need to use 100dvh as described on https://web.dev/blog/viewport-units?hl=de Fixed that. -
core-ci voted on patch set 10 V +1 01/17/25, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72615
-
Benjamin Franzke uploaded patch set 11
V +101/17/25, 14:53
-
core-ci voted on patch set 11 V +1 01/17/25, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72620
-
Benjamin Franzke voted on patch set 11 CR -2 01/17/25, 15:27
-
Benjamin Franzke marked it work in progress 01/17/25, 15:28
-
Benjamin Franzke uploaded patch set 12
V +102/07/25, 14:21Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 12 V -1 02/07/25, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73736
-
Benjamin Franzke uploaded patch set 13
V -102/07/25, 14:51Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 13 V -1 02/07/25, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73743
-
Benjamin Franzke uploaded patch set 14
V -102/07/25, 15:46 -
core-ci voted on patch set 14 V +1 02/07/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73749
-
Georg Ringer voted on patch set 14 CR +1 V +1 02/09/25, 21:20
-
Benjamin Franzke uploaded patch set 15
CR +1V +102/28/25, 15:25Rebase -
core-ci voted on patch set 15 V +1 02/28/25, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74909
-
Benjamin Franzke uploaded patch set 16
V +103/01/25, 17:40 -
core-ci voted on patch set 16 V -1 03/01/25, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74944
-
core-ci voted on patch set 16 V +1 03/01/25, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74944
-
core-ci voted on patch set 16 V -1 03/01/25, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74945
-
Benjamin Franzke uploaded patch set 17
V -103/03/25, 11:33 -
core-ci voted on patch set 17 V +1 03/03/25, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75005
-
core-ci voted on patch set 17 V -1 03/03/25, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75008
-
Benjamin Franzke uploaded patch set 18
V -103/03/25, 20:19 -
core-ci voted on patch set 18 V +1 03/03/25, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75046
-
core-ci voted on patch set 18 V -1 03/03/25, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75047
-
Benjamin Franzke rebased onto patch set 19
V -103/03/25, 21:36 -
core-ci voted on patch set 19 V +1 03/03/25, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75054
-
Benjamin Franzke abandoned the change 03/24/25, 10:37
Will be fixed via: 88588: [TASK] Remove collapsing docheader and move to scaffold grid | https://review.typo3.org/c/Packages/TYPO3.CMS/+/88588
_scaffold.scss:35