Review main Abandoned

87779[BUGFIX] Scroll the main document instead of .module

Benjamin Franzke CR 0 V 0 Normal +56 −134 updated 03/24/25, 10:37

Commit message

…and drop scrolling="no" from module iframe.

Utilize the root element scroller instead of scrolling on `.module`
and remove previous hacks which were mainly used to prevent browser
rebounce animation in iOS devices for refresh gestures of the module
iframe.

This allows dropdown and popovers (which are appended to `<body>`) to be
scrolled synchronously.
CKEditor dropdowns therefore now scroll smoothly instead of having to
be replaced on scroll and the flatpickr datepicker dropdown is now
scrolling instead of staying were it was initially opened.

Also debug output added globally via `<f:debug>` becomes scrollable and
the CKEditor development inspector is no longer overlayed over the
FormEngine form fields (which blocked them to be used).

The change removes previous hacks added in:
 * #98710: .with-overflow class which was used to overwrity
           body overflow:hidden in modal iframes
 * #105238: quicks in tests to stabilize #98710
 * #80116: moved scroll container from body to .module-body,
 * #91606: scroll-event workarounds for the datetime picker

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 19

Review log 2547

Show 1322 earlier messages
  1. Benjamin Franzke uploaded patch set 1 01/16/25, 11:27

  2. Benjamin Franzke uploaded patch set 2 01/16/25, 11:28

  3. core-ci voted on patch set 1 V -1 01/16/25, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72556

  4. core-ci voted on patch set 2 V -1 01/16/25, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72557

  5. Benjamin Franzke uploaded patch set 3 V -1 01/16/25, 13:04

  6. core-ci voted on patch set 3 V -1 01/16/25, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72558

  7. Benjamin Franzke uploaded patch set 4 V -1 01/17/25, 08:33

  8. Benjamin Franzke uploaded patch set 5 01/17/25, 08:33

  9. core-ci voted on patch set 5 V -1 01/17/25, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72603

  10. Benjamin Franzke uploaded patch set 6 V -1 01/17/25, 09:03

  11. core-ci voted on patch set 6 V -1 01/17/25, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72605

  12. Benjamin Franzke uploaded patch set 7 V -1 01/17/25, 09:23

  13. core-ci voted on patch set 7 V -1 01/17/25, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72607

  14. Benjamin Franzke uploaded patch set 8 V -1 01/17/25, 09:36

  15. core-ci voted on patch set 8 V +1 01/17/25, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72609

  16. Benjamin Franzke uploaded patch set 9 V +1 01/17/25, 09:56

  17. core-ci voted on patch set 9 V +1 01/17/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72611

  18. Andreas Kienast commented on patch set 9 01/17/25, 10:34

    _scaffold.scss:35

    This probably needs to be 100vh as the tab bar in mobile browsers may have variable height.
  19. Benjamin Franzke uploaded patch set 10 V +1 01/17/25, 13:09

  20. Benjamin Franzke commented on patch set 10 01/17/25, 13:09

    _scaffold.scss:35 Reply

    thx for noticing. 100% is actually fine here (acts like 100dvh), but 100vh used below became now became inaccurate, now that the root is scrollable, as 100vh now includes the (possibly hiding) scrollbar, therefore we need to use 100dvh as described on https://web.dev/blog/viewport-units?hl=de Fixed that.
  21. core-ci voted on patch set 10 V +1 01/17/25, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72615

  22. Benjamin Franzke uploaded patch set 11 V +1 01/17/25, 14:53

  1. core-ci voted on patch set 11 V +1 01/17/25, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72620

  2. Benjamin Franzke voted on patch set 11 CR -2 01/17/25, 15:27

  3. Benjamin Franzke marked it work in progress 01/17/25, 15:28

  4. Benjamin Franzke uploaded patch set 12 V +1 02/07/25, 14:21

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  5. core-ci voted on patch set 12 V -1 02/07/25, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73736

  6. Benjamin Franzke uploaded patch set 13 V -1 02/07/25, 14:51

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  7. core-ci voted on patch set 13 V -1 02/07/25, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73743

  8. Benjamin Franzke uploaded patch set 14 V -1 02/07/25, 15:46

  9. core-ci voted on patch set 14 V +1 02/07/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73749

  10. Georg Ringer voted on patch set 14 CR +1 V +1 02/09/25, 21:20

  11. Benjamin Franzke uploaded patch set 15 CR +1 V +1 02/28/25, 15:25

    Rebase
  12. core-ci voted on patch set 15 V +1 02/28/25, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74909

  13. Benjamin Franzke uploaded patch set 16 V +1 03/01/25, 17:40

  14. core-ci voted on patch set 16 V -1 03/01/25, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74944

  15. core-ci voted on patch set 16 V +1 03/01/25, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74944

  16. core-ci voted on patch set 16 V -1 03/01/25, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74945

  17. Benjamin Franzke uploaded patch set 17 V -1 03/03/25, 11:33

  18. core-ci voted on patch set 17 V +1 03/03/25, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75005

  19. core-ci voted on patch set 17 V -1 03/03/25, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75008

  20. Benjamin Franzke uploaded patch set 18 V -1 03/03/25, 20:19

  21. core-ci voted on patch set 18 V +1 03/03/25, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75046

  22. core-ci voted on patch set 18 V -1 03/03/25, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75047

  23. Benjamin Franzke rebased onto patch set 19 V -1 03/03/25, 21:36

  24. core-ci voted on patch set 19 V +1 03/03/25, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75054

  25. Benjamin Franzke abandoned the change 03/24/25, 10:37

    Will be fixed via: 88588: [TASK] Remove collapsing docheader and move to scaffold grid | https://review.typo3.org/c/Packages/TYPO3.CMS/+/88588