Review main Merged

87781[BUGFIX] Elevate tree starting points to abstract class

Andreas Kienast CR +2 V +2 Normal +21 −31 updated 03/25/25, 20:34

Commit message

The event `ModifyTreeDataEvent` accepts any tree of type
`AbstractTableConfigurationTreeDataProvider`. However, the only existing
event listener treats the tree as of type `DatabaseTreeDataProvider` by
using its `$startingPoints` attribute, which breaks as soon the event
`ModifyTreeDataEvent` is dispatched with another tree implementation
that is compatible with `AbstractTableConfigurationTreeDataProvider`.

To solve this, the `$startingPoints` and its getter/setter have been
moved to the abstract class, which also fixes one ignored phpstan issue.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1827

Show 12 earlier messages
  1. Andreas Kienast uploaded patch set 1 01/16/25, 15:20

  2. core-ci voted on patch set 1 V -1 01/16/25, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72565

  1. Andreas Kienast uploaded patch set 2 V -1 01/16/25, 15:29

  2. Andreas Kienast uploaded patch set 3 01/16/25, 15:35

  3. core-ci voted on patch set 2 V +1 01/16/25, 15:37 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72567

  4. core-ci voted on patch set 3 V +1 01/16/25, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72568

  5. Benni Mack voted on patch set 3 CR +1 01/22/25, 11:54

  6. Andreas Kienast commented on patch set 3 02/27/25, 08:30

    CategoryPermissionsAspect.php:70

    The whole loop is pointless now.
  7. Andreas Kienast voted on patch set 3 CR -1 02/27/25, 08:36

  8. Andreas Kienast uploaded patch set 4 CR +1 V +1 03/04/25, 07:07

  9. core-ci voted on patch set 4 V -1 03/04/25, 07:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75070

  10. Andreas Kienast uploaded patch set 5 V -1 03/04/25, 07:47

  11. Andreas Kienast uploaded patch set 6 03/04/25, 07:49

  12. core-ci voted on patch set 5 V +1 03/04/25, 07:56 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 6 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75072

  13. core-ci voted on patch set 6 V +1 03/04/25, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75073

  14. Andreas Kienast rebased onto patch set 7 V +1 03/25/25, 09:03

  15. Andreas Kienast commented on patch set 7 03/25/25, 09:05

    CategoryPermissionsAspect.php:70 Reply

    Done
  16. Georg Ringer commented on patch set 7 03/25/25, 09:08

    can we keep the int[]?
  17. core-ci voted on patch set 7 V +1 03/25/25, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76219

  18. Andreas Kienast uploaded patch set 8 V +1 03/25/25, 09:25

  19. Andreas Kienast commented on patch set 8 03/25/25, 09:26

    Reply

    done
  20. core-ci voted on patch set 8 V +1 03/25/25, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76222

  21. Benni Mack updated the commit message in patch set 9 V +1 03/25/25, 10:08

  22. Benni Mack voted on patch set 9 CR +1 V +1 03/25/25, 10:08

  23. core-ci voted on patch set 9 V +1 03/25/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76230

  24. Georg Ringer voted on patch set 9 CR +2 V +2 03/25/25, 20:34

  25. Georg Ringer merged patch set 10 03/25/25, 20:34