Review main Abandoned

87785[BUGFIX] Force chash for EXT:seo sitemap argument

Georg Ringer CR 0 V 0 Normal +45 −40 updated 04/08/25, 19:04

Commit message

To avoid cache issues the argument `tx_seo[sitemap]` enforces now a cHash.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 1116

  1. Georg Ringer uploaded patch set 1 01/16/25, 21:37

  2. Georg Ringer commented on patch set 1 01/16/25, 21:37

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 01/16/25, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72575

  4. Georg Ringer uploaded patch set 2 V -1 01/16/25, 22:01

  5. core-ci voted on patch set 2 V -1 01/16/25, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72576

  6. Georg Ringer uploaded patch set 3 V -1 01/18/25, 05:38

  7. core-ci voted on patch set 3 V -1 01/18/25, 05:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72654

  8. Georg Ringer uploaded patch set 4 V -1 01/20/25, 19:15

  9. core-ci voted on patch set 4 V +1 01/20/25, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72740

  10. Georg Ringer uploaded patch set 5 V +1 02/18/25, 16:13

  11. Benni Mack commented on patch set 5 02/18/25, 16:14

    IMHO, if we say that people need to set "enforceValidation" then we do not need this change. I actually prepared a patch to have enforceValidation turned on all the time.
  12. core-ci voted on patch set 5 V +1 02/18/25, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74337

  13. Georg Ringer commented on patch set 5 02/18/25, 17:48

    @benni@typo3.org fine for me as well. I just wanted to rebase the change to fit the latest version
  14. Benni Mack commented on patch set 5 02/19/25, 21:47

    Reply Unresolved

    https://review.typo3.org/c/Packages/TYPO3.CMS/+/87422 there is the version of me. I think it's good to have it in cross-ref, because your test adaptions are good.
  15. Benni Mack commented on patch set 5 04/08/25, 19:01

    We can now abandon this in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/87422
  16. Georg Ringer abandoned the change 04/08/25, 19:04