87789[TASK] Make CacheHashCalculator stateless and use via DI
Commit message
Review
-
Code review CR -1
- Stefan Bürk +1
- Oliver Hader -1
-
Verified V +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1116
-
Anja Leichsenring uploaded patch set 1 01/17/25, 10:39
-
core-ci voted on patch set 1 V +1 01/17/25, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72613
-
Oliver Hader commented on patch set 1 01/20/25, 09:53
What do you think about using DI for `CacheHashConfiguration` (via factory) and have that injectable in the constructor of `CacheHashCalculator` (which would be a service then)? -
Anja Leichsenring uploaded patch set 2
V +101/21/25, 17:16 -
Anja Leichsenring commented on patch set 2 01/21/25, 17:19
Reply
thanks for the input. Going with the approach now to not inject the configuration at all, but create the DTO whereever necessary. Next step will be removing the extensibility of the configuration, that will only be done by GLOBALS config. -
Anja Leichsenring uploaded patch set 3 01/21/25, 17:22
-
core-ci voted on patch set 2 V +1 01/21/25, 17:22 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72796
-
Anja Leichsenring uploaded patch set 4
V +101/21/25, 17:22 -
Anja Leichsenring uploaded patch set 5 01/21/25, 17:25
-
core-ci voted on patch set 3 V +1 01/21/25, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72797
-
core-ci voted on patch set 4 V +1 01/21/25, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72799
-
core-ci voted on patch set 5 V +1 01/21/25, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72800
-
Stefan Bürk voted on patch set 5 CR +1 V +1 01/24/25, 10:21
-
Oliver Hader commented on patch set 5 CR -1 01/24/25, 10:32
Unresolved
What is the goal of this change? Getting rid of the `SingletonInterface`, that fine. However, the remaining changes do not seem to fit with the commit message. The current change now implicitly relies of `$GLOBALS` through `CacheHashConfiguration`. -
Benni Mack marked it work in progress 03/20/25, 08:37
-
Anja Leichsenring abandoned the change 10/07/26, 04:56