Review main Merged

87790[BUGFIX] Improve viewport height handling with dynamic units

Benjamin Kott CR +2 V +2 Normal +44 −42 updated 01/20/25, 14:33

Commit message

Replaced static viewport height units with dynamic viewport units to
address inconsistencies in how browsers handle viewport size changes.
Static units fail to adapt when browser UI components like the address
bar or tab bar change visibility or size, particularly on mobile devices
such as iOS, iPadOS, and Android.

While Android browsers respect the fixed-frame structure of the backend,
iPadOS calculates viewport heights as if scrolling were enabled, leading
to layout issues—especially in Safari with multiple tabs open.

By switching to dynamic viewport units, the layout now adjusts to
changes in browser controls, ensuring accurate spacing and accessibility
for all interface elements, even at the bottom of the screen.

Additionally, the view module’s maximum size calculation has been
updated to correctly account for the docheader. This ensures consistent
sizing across all views and improves alignment with the updated viewport
handling logic.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 913

  1. Benjamin Kott uploaded patch set 1 01/17/25, 13:12

  2. core-ci voted on patch set 1 V +1 01/17/25, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72616

  3. Benjamin Kott updated the commit message in patch set 2 V +1 01/17/25, 13:40

  4. core-ci voted on patch set 2 V +1 01/17/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72617

  5. Benjamin Franzke updated the commit message in patch set 3 V +1 01/17/25, 14:31

  6. core-ci voted on patch set 3 V +1 01/17/25, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72618

  7. Andreas Kienast commented on patch set 3 01/17/25, 15:55

    * typo3/sysext/core/Resources/Private/Templates/ErrorPage/Error.html * typo3/sysext/core/Classes/Error/DebugExceptionHandler.php both still use `height: 100vh;`, do they need adaption as well?
  8. Benjamin Kott uploaded patch set 4 CR +1 V +1 01/20/25, 08:14

  9. core-ci voted on patch set 4 V +1 01/20/25, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72703

  10. Benjamin Franzke commented on patch set 4 CR +1 V +1 01/20/25, 09:37

    Reply

    Done
  11. Andreas Kienast voted on patch set 4 CR +1 V +1 01/20/25, 14:18

  12. Benjamin Franzke voted on patch set 4 CR +2 V +2 01/20/25, 14:22

  13. Benjamin Franzke merged patch set 5 01/20/25, 14:33