87790[BUGFIX] Improve viewport height handling with dynamic units
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 17
- Build/Sources/Sass/component/_autocomplete.scss+1 −1
- Build/Sources/Sass/component/_dropdown.scss+1 −1
- Build/Sources/Sass/component/_modal.scss+6 −6
- Build/Sources/Sass/component/_module.scss+1 −1
- Build/Sources/Sass/scaffold/_scaffold.scss+4 −4
- Build/Sources/Sass/scaffold/_toolbar.scss+3 −3
- Build/Sources/Sass/typo3/_element_cropper.scss+1 −1
- Build/Sources/Sass/typo3/_login_screen.scss+1 −1
- Build/Sources/Sass/workspace.scss+2 −2
- Build/Sources/TypeScript/backend/code-editor/element/code-mirror-element.ts+1 −1
- Build/Sources/TypeScript/viewpage/main.ts+3 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+14 −14
- typo3/sysext/backend/Resources/Public/JavaScript/code-editor/element/code-mirror-element.js+1 −1
- typo3/sysext/core/Classes/Error/DebugExceptionHandler.php+1 −1
- typo3/sysext/core/Resources/Private/Templates/ErrorPage/Error.html+1 −1
- typo3/sysext/viewpage/Resources/Public/JavaScript/main.js+1 −1
- typo3/sysext/workspaces/Resources/Public/Css/preview.css+2 −2
Review log 913
-
Benjamin Kott uploaded patch set 1 01/17/25, 13:12
-
core-ci voted on patch set 1 V +1 01/17/25, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72616
-
Benjamin Kott updated the commit message in patch set 2
V +101/17/25, 13:40 -
core-ci voted on patch set 2 V +1 01/17/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72617
-
Benjamin Franzke updated the commit message in patch set 3
V +101/17/25, 14:31 -
core-ci voted on patch set 3 V +1 01/17/25, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72618
-
Andreas Kienast commented on patch set 3 01/17/25, 15:55
* typo3/sysext/core/Resources/Private/Templates/ErrorPage/Error.html * typo3/sysext/core/Classes/Error/DebugExceptionHandler.php both still use `height: 100vh;`, do they need adaption as well? -
Benjamin Kott uploaded patch set 4
CR +1V +101/20/25, 08:14 -
core-ci voted on patch set 4 V +1 01/20/25, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72703
-
Benjamin Franzke commented on patch set 4 CR +1 V +1 01/20/25, 09:37
Reply
Done -
Andreas Kienast voted on patch set 4 CR +1 V +1 01/20/25, 14:18
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 01/20/25, 14:22
-
Benjamin Franzke merged patch set 5 01/20/25, 14:33