87791[BUGFIX] Replace extended ColumnDiff by using PHP Reflection API
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1215
-
Stefan Bürk uploaded patch set 1 01/17/25, 15:36
-
core-ci voted on patch set 1 V +1 01/17/25, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72621
-
Benjamin Franzke commented on patch set 1 01/17/25, 16:14
-
Benjamin Franzke commented on patch set 1 01/17/25, 16:23
ColumnDiff.php:24Replynvm, I guess the second case applies escaping to the diff initialized in https://github.com/TYPO3/typo3/blob/052b80b2d0b49bb6c3078e943b4a2ba1babd512b/typo3/sysext/core/Classes/Database/Schema/TableDiff.php#L235 (maybe we could escape directly). anyway, I'll close this comment for now. -
Stefan Bürk commented on patch set 1 CR -1 01/17/25, 16:28
ColumnDiff.php:24Reply> It seems like oldColumn is quoted twice: Nope, `buildQuoteColumn()` unquotes the name first, see https://github.com/TYPO3/typo3/blob/052b80b2d0b49bb6c3078e943b4a2ba1babd512b/typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php#L1494 Otherwise, good point. Checking now if we can drop the extended ColumnDiff completly. -
Sebastian Iffland commented on patch set 1 01/17/25, 16:41
ColumnDiff.php:118As targeting branches supporting PHP 8.3+ I'd propose applying [#\[\Override\]](https://php.watch/versions/8.3/override-attr)attribute. -
Sebastian Iffland commented on patch set 1 01/17/25, 16:43
ColumnDiff.php:118Replynvm, just checked development roadmap and 13.4 still provides support for 8.2 -
Stefan Bürk uploaded patch set 2
CR -1V +101/17/25, 17:04 -
core-ci voted on patch set 2 V +1 01/17/25, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72630
-
Benjamin Franzke commented on patch set 2 01/17/25, 17:15
ColumnDiff.php:24Replythat should actually work by composing a new `ColumnDiff` object instead of modyfing the existing one. Tried this here, maybe we can pick that route: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87792 -
Stefan Bürk commented on patch set 2 01/17/25, 17:15
ColumnDiff.php:24Reply@ben@bnf.dev Switched to reflection in the one place in ConnectionMigrator to make the custom ColumnDiff obsolete and removed it. Also removed the dbal rise from this change now, we can do that in a dedicated change. Does the solution now goes in the direction you had in mind ? -
Benjamin Franzke commented on patch set 2 01/17/25, 17:17
ColumnDiff.php:24Replyyes, but then I figured we do not need reflection at all, as we can compose a new instance. Sorry, we overlapped here, I tried that in https://review.typo3.org/c/Packages/TYPO3.CMS/+/87792 in parallel to your change, sorry :\ -
core-ci commented on patch set 2 01/17/25, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72631
-
Stefan Bürk commented on patch set 2 01/17/25, 17:28
ColumnDiff.php:24Reply UnresolvedEverything fine, going to abandon mine in favor of yours to also avoid the reflection. -
Stefan Bürk abandoned the change 01/17/25, 17:29
ColumnDiff.php:24