Review main Merged

87792[BUGFIX] Remove ColumnDiff overwrite to support doctrine/dbal 4.2.2

Benjamin Franzke CR +2 V +2 Normal +8 −134 updated 01/17/25, 19:35

Commit message

The doctrine `Doctrine/DBAL 4.2.2` [1] release includes a change to
consider column platform options as changed to support PostgreSQL
`JSONB`.

The newly introduced method `ColumnDiff::hasPlatformOptionsChanged()`
tries to access the private properties `newColumn` and `oldColumn`
which are not accessible in the TYPO3 extended `ColumnDiff` class.
This extended class replaced these private properties by publicly
modifiable ones. This lead to a TypeError during the database compare
for PostgreSQL with Doctrine DBAL 4.2.2.

To mitigate this issue object composition instead of object
modification is used to apply quoting to the ColumnDiff oldColumn
without the need for a custom ColumnDiff implementation.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 812

  1. Benjamin Franzke uploaded patch set 1 01/17/25, 16:19

  2. Benjamin Franzke uploaded patch set 2 01/17/25, 16:27

  3. core-ci voted on patch set 2 V -1 01/17/25, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72625

  4. core-ci commented on patch set 2 01/17/25, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72626

  5. Benjamin Franzke uploaded patch set 3 V -1 01/17/25, 17:13

  6. core-ci voted on patch set 3 V +1 01/17/25, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72632

  7. Stefan Bürk commented on patch set 3 01/17/25, 17:31

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 01/17/25, 17:38

  9. core-ci commented on patch set 3 01/17/25, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72633

  10. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/17/25, 17:49

  11. Benjamin Franzke voted on patch set 3 CR +2 V +2 01/17/25, 19:28

  12. Benjamin Franzke merged patch set 4 01/17/25, 19:35