Review main Abandoned

87793[BUGFIX] Improve accessibility of module-menu - menu-test horizontal+vertical

Ayke Halder CR 0 V 0 Normal +101 −39 updated 04/01/26, 15:00

Commit message

horizontal+vertical

This improves the accessibility of the module-menu:

* Always focus first entry of sub-menu on ENTER/SPACE - even if
  sub-menu is already open.
* Announce Name of sub-menu via `aria-label`.
* Relate sub-menu and sub-menu-button via `aria-controls`
* Mark non-menu html-tags as `role=presentation`.

Before this change pressing ENTER/SPACE on an already opened sub-menu
did close the sub-menu instead of focusing the first entry.

To close a sub-menu use ESC either from inside sub-menu (like before)
or when trigger-button is focused (new).

This introduces an option to provide an intended state for the
menu-toggle mechanism. Thereby the result can be set instead of just
toggling the current state.

This fixes a minor bug caused by 'TWBS Collapse' defaults that
automatically triggers a toggle on init.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 3

Review log 23

  1. Ayke Halder uploaded patch set 1 01/17/25, 16:20

  2. core-ci voted on patch set 1 V +1 01/17/25, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72623

  3. Ayke Halder abandoned the change 04/01/26, 15:00