Review main Merged

87805[BUGFIX] Load full TypoScript setup in RedirectService

Torben Hansen CR +2 V +2 Easy +3 −1 updated 01/27/25, 12:23

Commit message

When a redirect is configured to use a `RecordLinkHandler`, the
redirect will fail with an exception, when the TypoScript setup
array is not available. This is the case, when at least one
regular page has been rendered.

With this change, it is ensured, that the full TypoScript
setup array is initialized in RedirectService, so later
creation of links in `DatabaseRecordLinkBuilder` will
have access to the full setup array via the
`frontend.typoscript` request attribute.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Thomas Hohn +1
    • Garvin Hicking +1
    • Markus Klein +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1314

  1. Torben Hansen uploaded patch set 1 01/18/25, 14:09

  2. core-ci voted on patch set 1 V +1 01/18/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72661

  3. Oliver Hader voted on patch set 1 CR +1 01/23/25, 14:33

  4. Markus Klein voted on patch set 1 CR +1 01/23/25, 14:34

  5. Oliver Hader voted on patch set 1 V +1 01/23/25, 14:47

  6. Oliver Hader commented on patch set 1 01/23/25, 14:48

    Tested main & v13
  7. Torben Hansen commented on patch set 1 01/23/25, 15:00

    Note: v12 backport will be different (see https://forge.typo3.org/issues/102892#note-20). Maybe, we fix this for v12 in a dedicated patch. v12 is IMO however important, since the issue is present since v12 and should be fixed.
  8. Georg Ringer voted on patch set 1 CR +1 V +1 01/23/25, 19:10

  9. Garvin Hicking voted on patch set 1 CR +1 V +1 01/23/25, 22:33

  10. Thomas Hohn voted on patch set 1 CR +1 01/24/25, 07:05

  11. Stefan Bürk commented on patch set 1 CR -1 01/24/25, 07:51

    Reviewing ...
  12. Stefan Bürk commented on patch set 1 CR +2 V +2 01/24/25, 09:04

    Reply

    @derhansen@gmail.com thanks for the change and communication/notes in the issue.
  13. Stefan Bürk merged patch set 2 01/24/25, 09:04

  14. Christian Kuhn voted on patch set 2 CR +1 01/27/25, 12:23