87806[TASK] Refine site set error handling
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Lina Wolf +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Lina Wolf +1
- core-ci +1 CI
Issues 2
Files 24
- Build/Scripts/runTests.sh+1 −1
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+3 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf+12 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Overview.html+27 −0
- typo3/sysext/core/Classes/Command/SiteSetsListCommand.php+26 −0
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+36 −25
- typo3/sysext/core/Classes/Site/Set/InvalidCategoryDefinitionsException.phpnew+41 −0
- typo3/sysext/core/Classes/Site/Set/InvalidSetException.php+22 −1
- typo3/sysext/core/Classes/Site/Set/InvalidSettingsException.php+3 −0
- typo3/sysext/core/Classes/Site/Set/SetError.php+4 −0
- typo3/sysext/core/Classes/Site/Set/SetRegistry.php+20 −7
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php+152 −52
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+8 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/EmptySettings/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/EmptySettings/settings.yamlnew+0 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidChainedDependeny/config.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSetMissingLabel/config.yamlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettings/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettings/settings.yamlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettingsDefinitionsInvalidType/config.yamlnew+2 −0
Show 4 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettingsDefinitionsInvalidType/settings.definitions.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettingsDefinitionsMissingProperties/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettingsDefinitionsMissingProperties/settings.definitions.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Site/Set/SetRegistryTest.php+62 −3
Review log 2336
Show 611 earlier messages
-
Benjamin Franzke uploaded patch set 1 01/18/25, 16:00
-
core-ci voted on patch set 1 V +1 01/18/25, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72662
-
Benjamin Franzke uploaded patch set 2
V +101/19/25, 19:59 -
core-ci voted on patch set 2 V -1 01/19/25, 20:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72687
-
Benjamin Franzke uploaded patch set 3
V -101/20/25, 08:33 -
core-ci voted on patch set 3 V +1 01/20/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72708
-
Benjamin Franzke marked it work in progress 01/20/25, 10:26
-
Benjamin Franzke uploaded patch set 4
V +101/21/25, 16:51 -
core-ci voted on patch set 4 V -1 01/21/25, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72794
-
Benjamin Franzke uploaded patch set 5
V -101/21/25, 17:03 -
core-ci voted on patch set 5 V -1 01/21/25, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72795
-
Benjamin Franzke uploaded patch set 6
V -102/04/25, 08:29 -
Benjamin Franzke marked it ready for review 02/04/25, 08:30
-
core-ci voted on patch set 6 V -1 02/04/25, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73468
-
Benjamin Franzke uploaded patch set 7
V -102/04/25, 08:39 -
core-ci voted on patch set 7 V +1 02/04/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73469
-
Lina Wolf commented on patch set 7 02/04/25, 17:51
While I do think that your sollution is very helpful it does not solve the original issue https://forge.typo3.org/issues/105793. If a set is invalid because it depends on an invalid set somewhere down the dependency chain it is not listed as invalid. For example, we have two set: name: t3docs/examples label: Example set dependencies: - t3docs/examplesxxx and name: t3docs/examples-hmenu label: "Examples: HMENU special userfunc" dependencies: - t3docs/examples now t3docs/examples is listed as invalid set. However t3docs/examples-hmenu is also invalid as it depends on an invalid set, however it is NOT listed as invalid in your solution provided here. -
Benjamin Franzke marked it work in progress 02/04/25, 18:57
-
Lina Wolf uploaded patch set 8
V +102/04/25, 19:21 -
Lina Wolf commented on patch set 8 02/04/25, 19:22
Added a failing functional test to demonstrate the issue -
core-ci voted on patch set 8 V -1 02/04/25, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73531
-
Benjamin Franzke uploaded patch set 9
V -102/05/25, 07:25 -
Benjamin Franzke commented on patch set 9 02/05/25, 07:25
Reply
Thanks for your investigation, fixed!Reply
Thanks, fixed! -
core-ci voted on patch set 9 V +1 02/05/25, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73554
-
Benjamin Franzke uploaded patch set 10
V +102/05/25, 08:50 -
core-ci voted on patch set 10 V -1 02/05/25, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73563
-
Benjamin Franzke uploaded patch set 11
V -102/05/25, 12:43 -
core-ci voted on patch set 11 V -1 02/05/25, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73580
-
Benjamin Franzke uploaded patch set 12
V -102/05/25, 13:19 -
core-ci voted on patch set 12 V +1 02/05/25, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73584
-
Lina Wolf uploaded patch set 13
V +102/05/25, 14:56 -
Lina Wolf commented on patch set 13 CR +1 V +1 02/05/25, 14:57
I fixed the grammar of one sentence in the locallang file other then that the code looks good and works as expected. This would fix the bug I reported and be helpful in general when using site sets -
core-ci voted on patch set 13 V +1 02/05/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73589
-
Garvin Hicking commented on patch set 13 CR +1 V +1 02/06/25, 09:12
Great, covered all variants I could think of to test. I believe this to be very helpful for integrators going forward, thank you. :) -
Benjamin Franzke voted on patch set 13 CR +2 V +2 02/06/25, 15:20
-
Benjamin Franzke merged patch set 14 02/06/25, 15:34