Review main Merged

87806[TASK] Refine site set error handling

Benjamin Franzke CR +2 V +2 Hard +440 −91 updated 02/06/25, 15:34

Commit message

Show errors for all site set errors in site overview and
site:sets:list console commands.

It turned out that site set errors for site sets that have not
yet been assigned to a site are hard to figure out for integrators by
using the TYPO3 error log, as we only show errors for site sets that
have been assigned in the site overview and settings module.

Therefore all site set errors are streamlined
to be shown in the site overview and command listings and to contain
additional information for the cause of the failure:
 * Invalid or missing properties are reflected in order to understand
   why settings or set definitions fail to be loaded
 * YAML parse errors are now listed
 * Chained dependency errors are now detected and reported

Empty settings.yaml in sets are no longer considered an error
in order for extension templates to be able to ship this file
with comments, but without any concrete contents.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 2

Files 24

Show 4 more files

Review log 2336

Show 611 earlier messages
  1. Benjamin Franzke uploaded patch set 1 01/18/25, 16:00

  2. core-ci voted on patch set 1 V +1 01/18/25, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72662

  3. Benjamin Franzke uploaded patch set 2 V +1 01/19/25, 19:59

  4. core-ci voted on patch set 2 V -1 01/19/25, 20:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72687

  5. Benjamin Franzke uploaded patch set 3 V -1 01/20/25, 08:33

  6. core-ci voted on patch set 3 V +1 01/20/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72708

  7. Benjamin Franzke marked it work in progress 01/20/25, 10:26

  8. Benjamin Franzke uploaded patch set 4 V +1 01/21/25, 16:51

  9. core-ci voted on patch set 4 V -1 01/21/25, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72794

  10. Benjamin Franzke uploaded patch set 5 V -1 01/21/25, 17:03

  11. core-ci voted on patch set 5 V -1 01/21/25, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72795

  1. Benjamin Franzke uploaded patch set 6 V -1 02/04/25, 08:29

  2. Benjamin Franzke marked it ready for review 02/04/25, 08:30

  3. core-ci voted on patch set 6 V -1 02/04/25, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73468

  4. Benjamin Franzke uploaded patch set 7 V -1 02/04/25, 08:39

  5. core-ci voted on patch set 7 V +1 02/04/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73469

  6. Lina Wolf commented on patch set 7 02/04/25, 17:51

    While I do think that your sollution is very helpful it does not solve the original issue https://forge.typo3.org/issues/105793. If a set is invalid because it depends on an invalid set somewhere down the dependency chain it is not listed as invalid. For example, we have two set: name: t3docs/examples label: Example set dependencies: - t3docs/examplesxxx and name: t3docs/examples-hmenu label: "Examples: HMENU special userfunc" dependencies: - t3docs/examples now t3docs/examples is listed as invalid set. However t3docs/examples-hmenu is also invalid as it depends on an invalid set, however it is NOT listed as invalid in your solution provided here.
  7. Benjamin Franzke marked it work in progress 02/04/25, 18:57

  8. Lina Wolf uploaded patch set 8 V +1 02/04/25, 19:21

  9. Lina Wolf commented on patch set 8 02/04/25, 19:22

    Added a failing functional test to demonstrate the issue
  10. core-ci voted on patch set 8 V -1 02/04/25, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73531

  11. Benjamin Franzke uploaded patch set 9 V -1 02/05/25, 07:25

  12. Benjamin Franzke commented on patch set 9 02/05/25, 07:25

    Reply

    Thanks for your investigation, fixed!

    Reply

    Thanks, fixed!
  13. core-ci voted on patch set 9 V +1 02/05/25, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73554

  14. Benjamin Franzke uploaded patch set 10 V +1 02/05/25, 08:50

  15. core-ci voted on patch set 10 V -1 02/05/25, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73563

  16. Benjamin Franzke uploaded patch set 11 V -1 02/05/25, 12:43

  17. core-ci voted on patch set 11 V -1 02/05/25, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73580

  18. Benjamin Franzke uploaded patch set 12 V -1 02/05/25, 13:19

  19. core-ci voted on patch set 12 V +1 02/05/25, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73584

  20. Lina Wolf uploaded patch set 13 V +1 02/05/25, 14:56

  21. Lina Wolf commented on patch set 13 CR +1 V +1 02/05/25, 14:57

    I fixed the grammar of one sentence in the locallang file other then that the code looks good and works as expected. This would fix the bug I reported and be helpful in general when using site sets
  22. core-ci voted on patch set 13 V +1 02/05/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73589

  23. Garvin Hicking commented on patch set 13 CR +1 V +1 02/06/25, 09:12

    Great, covered all variants I could think of to test. I believe this to be very helpful for integrators going forward, thank you. :)
  24. Benjamin Franzke voted on patch set 13 CR +2 V +2 02/06/25, 15:20

  25. Benjamin Franzke merged patch set 14 02/06/25, 15:34