Review main Merged

87808[BUGFIX] Provide legacy initialization method for the color picker

Benjamin Franzke CR +2 V +2 Easy +27 −2 updated 01/20/25, 14:35

Commit message

The color picker is not explicitly marked as internal and was
therefore used by extension for custom backend modules.

With the color picker refactoring in #105552 the JavaScript module
was refactored to use a web component instead of a initializer
method, causing extension to break which import this module.

Provide the legacy interface with an implementation that relies
on the new webcomponent based API.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Benjamin Franzke commented on patch set 1 01/20/25, 08:33

    Cherry Picked from branch 13.4.
  2. Benjamin Franzke marked it ready for review 01/20/25, 08:33

  3. core-ci voted on patch set 1 V +1 01/20/25, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72707

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 01/20/25, 14:09

  5. Benjamin Franzke uploaded patch set 2 CR +1 V +1 01/20/25, 14:21

  6. core-ci voted on patch set 2 V +1 01/20/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72728

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 01/20/25, 14:29

  8. Benjamin Kott voted on patch set 2 CR +1 V +1 01/20/25, 14:34

  9. Benjamin Franzke voted on patch set 2 CR +2 V +2 01/20/25, 14:35

  10. Benjamin Franzke merged patch set 3 01/20/25, 14:35