Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Orphaned

87811[BUGFIX] Make expand functionality recognizable in LiveSearch

Oli Bartsch CR 0 V -1 Easy +2 −7 updated 04/22/26, 10:26

Commit message

The livesearch expand functionality, showing
more information for a search result, is
triggered by clicking on the right arrow
on a result item.

However, previously it was hard to understand,
that the result item triggers two different actions,
depending on whether the user clicks on the
item or directly on the arrow.

To improve this, corresponding border is
now always visible - which is especially
required for mobile devices.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/11/87811/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/11/87811/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 1

Files 2

Review log 57

  1. Oli Bartsch uploaded patch set 1 01/20/25, 10:27

  2. core-ci voted on patch set 1 V +1 01/20/25, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72719

  3. Andreas Kienast voted on patch set 1 V +1 01/20/25, 13:39

  4. Garvin Hicking commented on patch set 1 01/20/25, 15:50

    While this improves the situation, hovering now always highlights both link areas, it is IMO less clear that clicking the left portion of the links triggers something else than the small area button does. How about: - Keep the current border color change of this patch - But additionally, create a distinct hover effect (probably one more level of "elevation"?) depending on whether one hovers over the left or the right area? - Hover on "left side" of the link: Tint background of modal actively, tint left side of the link - Hover on "right side" of the link (">"): Tint right hand modal popup actively, tint right side of the link I've added a mockup of this idea in the ticket.
  5. Oli Bartsch commented on patch set 1 01/21/25, 09:36

    Reply Unresolved

    IMO they should just have two different hover states and having their own padding. Otherwise the display is odd.
  6. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 06:30

  7. core-ci voted on patch set 2 V -1 04/22/26, 07:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100713