Review main Merged

87814[BUGFIX] Re-allow saving nullable \DateTime properties as null

Alexander Schnitzler CR +2 V +2 Normal +97 −3 updated 01/25/25, 18:53

Commit message

If an entity property is a nullable \DateTime, which is also marked
nullable via TCA and which is stored as a DATETIME in the database,
a nulled property must be stored as null.

Currently, all null values are converted to 0000-00-00 00:00:00, which
is not only invalid but also not the desired value.

This change restores the former behaviour.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 810

  1. Alexander Schnitzler uploaded patch set 1 01/20/25, 13:36

  2. Alexander Schnitzler uploaded patch set 2 01/20/25, 13:40

  3. Alexander Schnitzler wrote 01/20/25, 13:43

    Topic set to extbase
  4. core-ci voted on patch set 1 V +1 01/20/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72725

  5. core-ci voted on patch set 2 V +1 01/20/25, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72727

  6. Benni Mack voted on patch set 2 CR +1 01/21/25, 12:39

  7. Torben Hansen voted on patch set 2 CR +1 V +1 01/25/25, 08:36

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 01/25/25, 09:05

  9. Benni Mack voted on patch set 2 CR +2 V +2 01/25/25, 18:53

  10. Benni Mack merged patch set 3 01/25/25, 18:53