Review main Merged

87817[TASK] Show only file name in file reference header button

Jasmina Ließmann CR +2 V +2 Normal +17 −58 updated 01/21/25, 14:55

Commit message

Previously, the file name and - if present - the file title
were displayed in file reference's header row.

Both were preceded by a label that indicated whether it
is the file name or title (even if there was no file title).

Depending on the length of the file name and the file title,
this took up different amounts of space. In addition, the
space available in .form-irre-header-button was also influenced
by the ratio of the preview image.

The ratio of the preview image gives the user an important
indication of which format it is, so this is retained. However,
to make the display clearer, now only the file name is displayed
above the thumbnail. This is in line with the display in the
file list module. Additionally, the labels, used to distinguish
between the file name and title are removed from the view.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1016

  1. Jasmina Ließmann uploaded patch set 1 01/20/25, 15:00

  2. core-ci voted on patch set 1 V -1 01/20/25, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72732

  3. Jasmina Ließmann uploaded patch set 2 V -1 01/20/25, 15:16

  4. core-ci voted on patch set 2 V -1 01/20/25, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72733

  5. Jasmina Ließmann uploaded patch set 3 V -1 01/20/25, 15:34

  6. core-ci voted on patch set 3 V -1 01/20/25, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72734

  7. Jasmina Ließmann uploaded patch set 4 V -1 01/20/25, 16:40

  8. core-ci voted on patch set 4 V +1 01/20/25, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72739

  9. Oli Bartsch uploaded patch set 5 V +1 01/20/25, 22:01

  10. core-ci voted on patch set 5 V -1 01/20/25, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72747

  11. Oli Bartsch uploaded patch set 6 V -1 01/20/25, 22:42

  12. core-ci voted on patch set 6 V +1 01/20/25, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72750

  13. Oli Bartsch voted on patch set 6 CR +1 V +1 01/21/25, 10:08

  14. Benni Mack voted on patch set 6 CR +1 V +1 01/21/25, 12:17

  15. Jasmina Ließmann voted on patch set 6 CR +2 V +2 01/21/25, 14:48

  16. Jasmina Ließmann merged patch set 7 01/21/25, 14:55