Review main Merged

87836[BUGFIX] Fix positioning of color preview

Andreas Kienast CR +2 V +2 Easy +15 −8 updated 01/23/25, 12:08

Commit message

The color preview element rendered within a color picker is rendered as
a block element, whereas `typo3-backend-color-picker` has no explicit
configuration, falling back to being an inline element.

The color picker element is now rendered as an inline block element,
fixing the positioning of the color preview element.

Also, the styling is now part of the web component itself.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Andreas Kienast uploaded patch set 1 01/21/25, 13:23

  2. core-ci voted on patch set 1 V +1 01/21/25, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72784

  3. Andreas Kienast uploaded patch set 2 V +1 01/21/25, 14:22

  4. core-ci voted on patch set 2 V +1 01/21/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72790

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 01/22/25, 08:50

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/22/25, 21:50

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 01/23/25, 11:54

  8. Andreas Kienast merged patch set 3 01/23/25, 12:08