Review main Merged

87837[FEATURE] Add stdWrap to htmlTag.attributes

Benni Mack CR +2 V +2 Normal +76 −1 updated 03/29/25, 09:27

Commit message

This change allows to use stdWrap in

  config.htmlTag.attributes.benni = nice
  config.htmlTag.attributes.benni.override = something

before it was only possible to use

  config.htmlTag.attributes.benni = nice

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1318

  1. Benni Mack uploaded patch set 1 01/21/25, 13:31

  2. core-ci voted on patch set 1 V -1 01/21/25, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72785

  3. Benni Mack marked it work in progress 01/22/25, 11:49

  4. Benni Mack rebased onto patch set 2 V -1 03/22/25, 14:19

  5. core-ci voted on patch set 2 V -1 03/22/25, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76024

  6. Benni Mack uploaded patch set 3 V -1 03/22/25, 16:10

  7. core-ci voted on patch set 3 V +1 03/22/25, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76033

  8. Benni Mack uploaded patch set 4 V +1 03/22/25, 16:30

  9. Benni Mack marked it ready for review 03/22/25, 16:30

  10. core-ci voted on patch set 4 V +1 03/22/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76035

  11. Garvin Hicking commented on patch set 4 03/22/25, 16:54

    Feature-106415-AddStdWrapToConfightmlTagattributesattr.rst:15

    ```suggestion has all stdWrap possibilities. This option is used to control the attributes of the single :html:`<html>` tag of a rendered page. ```

    Feature-106415-AddStdWrapToConfightmlTagattributesattr.rst:21

    Maybe also mention the possibility of applying a userfunc now?
  12. Benni Mack uploaded patch set 5 V +1 03/23/25, 21:25

  13. Benni Mack commented on patch set 5 03/23/25, 21:26

    Feature-106415-AddStdWrapToConfightmlTagattributesattr.rst:15 Reply

    Done

    Feature-106415-AddStdWrapToConfightmlTagattributesattr.rst:21 Reply

    Done
  14. core-ci voted on patch set 5 V +1 03/23/25, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76090

  15. Garvin Hicking voted on patch set 5 CR +1 V +1 03/24/25, 18:09

  16. Georg Ringer voted on patch set 5 CR +2 V +2 03/24/25, 20:38

  17. Georg Ringer merged patch set 6 03/24/25, 20:38

  18. Lina Wolf commented on patch set 6 03/29/25, 09:27