Review main Merged

87840[DOCS] Correct method name in changelog to CacheDataCollector

Chris Müller CR +2 V +2 Easy +1 −1 updated 01/22/25, 07:12

Commit message

There is no method "getLifetime()" in the CacheDataCollector.
Instead, it should be "resolveLifetime()" which returns the minimum
lifetime of all defined cache tags.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Chris Müller uploaded patch set 1 01/21/25, 17:22

  2. core-ci voted on patch set 1 V +1 01/21/25, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72798

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 01/21/25, 19:33

  4. Oliver Hader voted on patch set 1 CR +1 V +1 01/22/25, 00:15

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 01/22/25, 06:13

  6. Garvin Hicking merged patch set 2 01/22/25, 07:12