Review 12.4 Merged

87844[TASK] Update phpstan

Anja Leichsenring CR +2 V +2 Easy +9 −12 updated 01/22/25, 11:19

Commit message

Used commands:

^ Build/Scripts/runTests.sh -s composer require --dev \
	phpstan/phpstan:^2.1.2

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Anja Leichsenring uploaded patch set 1 01/22/25, 08:20

  2. core-ci voted on patch set 1 V +1 01/22/25, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72826

  3. Garvin Hicking commented on patch set 1 CR -1 01/22/25, 10:01

    composer.json / .lock changes look fishy
  4. Anja Leichsenring uploaded patch set 2 CR -1 V +1 01/22/25, 10:51

  5. core-ci voted on patch set 2 V +1 01/22/25, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72845

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 01/22/25, 11:19

  7. Garvin Hicking merged patch set 3 01/22/25, 11:19