Review main Merged

87846[TASK] Streamline checkerboard backgrounds

Andreas Kienast CR +2 V +2 Normal +30 −25 updated 01/22/25, 13:49

Commit message

A new SCSS mixin is added that allows to generate a checkerboard
background. This is utilized to streamline all occurrences of said
background pattern.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 811

  1. Andreas Kienast uploaded patch set 1 01/22/25, 10:19

  2. Andreas Kienast uploaded patch set 2 01/22/25, 10:20

  3. Andreas Kienast uploaded patch set 3 01/22/25, 10:23

  4. core-ci voted on patch set 1 V +1 01/22/25, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72834

  5. core-ci voted on patch set 2 V +1 01/22/25, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72835

  6. core-ci voted on patch set 3 V +1 01/22/25, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72836

  7. Garvin Hicking commented on patch set 3 CR +1 V +1 01/22/25, 11:37

    Works well for me, tested in the three areas (styleguide, cropper, colorpicker) in both dark and light mode, both firefox and chromium (OSX)
  8. Benni Mack voted on patch set 3 CR +1 V +1 01/22/25, 11:53

  9. Oliver Hader voted on patch set 3 CR +1 V +1 01/22/25, 13:19

  10. Andreas Kienast voted on patch set 3 CR +2 V +2 01/22/25, 13:29

  11. Andreas Kienast merged patch set 4 01/22/25, 13:49