87851[WIP][TASK] Allow newlines in site set definition description
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 69
-
Oliver Hader uploaded patch set 1 01/22/25, 11:55
-
Oliver Hader uploaded patch set 2 01/22/25, 12:00
-
core-ci voted on patch set 1 V +1 01/22/25, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72849
-
core-ci voted on patch set 2 V +1 01/22/25, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72852
-
Garvin Hicking updated the commit message in patch set 3
V +101/22/25, 18:03 -
Garvin Hicking commented on patch set 3 01/22/25, 18:04
How about using CSS "white-space: pre" instead, could that work too? -
core-ci voted on patch set 3 V +1 01/22/25, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72879
-
Oliver Hader commented on patch set 3 01/23/25, 15:07
Reply
Nice one! `white-space: pre` seems to be working, and is much simpler. I think we should go back into the issue and ask, what the reporter wanted to achieve. The report about `Yaml::parse` not supporting newlines seems to be invalid - that's what this PoC was meant for. -
Oliver Hader abandoned the change 01/23/25, 15:07
Just PoC