Review main Abandoned

87851[WIP][TASK] Allow newlines in site set definition description

Oliver Hader CR 0 V 0 Easy +9 −3 updated 01/23/25, 15:07

Commit message

This just demos how to render newlines in the backend user interface.
I’ve misused the definitions for “felogin” for that.

It can be tested by adding the following to the site config.yaml:

dependencies:
  - typo3/felogin

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 69

  1. Oliver Hader uploaded patch set 1 01/22/25, 11:55

  2. Oliver Hader uploaded patch set 2 01/22/25, 12:00

  3. core-ci voted on patch set 1 V +1 01/22/25, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72849

  4. core-ci voted on patch set 2 V +1 01/22/25, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72852

  5. Garvin Hicking updated the commit message in patch set 3 V +1 01/22/25, 18:03

  6. Garvin Hicking commented on patch set 3 01/22/25, 18:04

    How about using CSS "white-space: pre" instead, could that work too?
  7. core-ci voted on patch set 3 V +1 01/22/25, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72879

  8. Oliver Hader commented on patch set 3 01/23/25, 15:07

    Reply

    Nice one! `white-space: pre` seems to be working, and is much simpler. I think we should go back into the issue and ask, what the reporter wanted to achieve. The report about `Yaml::parse` not supporting newlines seems to be invalid - that's what this PoC was meant for.
  9. Oliver Hader abandoned the change 01/23/25, 15:07

    Just PoC