Review main Merged

87853[BUGFIX] Avoid creation of archive containing single file

Andreas Kienast CR +2 V +2 Normal +39 −15 updated 01/24/25, 07:15

Commit message

When a single file is selected and then downloaded in the filelist via
the "Download" action button, the file is now directly sent to the
client without creating a zip archive.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 78

  1. Andreas Kienast uploaded patch set 1 01/22/25, 12:45

  2. core-ci voted on patch set 1 V +1 01/22/25, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72857

  3. Benni Mack voted on patch set 1 CR +1 01/22/25, 15:49

  4. Benni Mack voted on patch set 1 V +1 01/22/25, 15:51

  5. Andreas Kienast commented on patch set 1 01/23/25, 14:04

    For documentation purposes: this patch is an alternative implementation for https://review.typo3.org/c/Packages/TYPO3.CMS/+/85474.
  6. Garvin Hicking commented on patch set 1 CR +1 V +1 01/23/25, 15:49

    Tried a lot to break this, but couldn't. Good approach! :)
  7. Andreas Kienast voted on patch set 1 CR +2 V +2 01/24/25, 06:58

  8. Andreas Kienast merged patch set 2 01/24/25, 07:15