Review main Merged

87868[TASK] Improve performance of page-based sitemap.xml generation

TYPO3com CR +2 V +2 Easy +3 −3 updated 04/08/25, 09:22

Commit message

The page object is handed in so the page
does not need to be loaded again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 813

  1. TYPO3com uploaded patch set 1 01/23/25, 14:12

  2. core-ci voted on patch set 1 V -1 01/23/25, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72932

  3. Benni Mack commented on patch set 1 01/23/25, 15:12

  4. Benni Mack uploaded patch set 2 V -1 03/28/25, 13:39

  5. core-ci voted on patch set 2 V -1 03/28/25, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76594

  6. Georg Ringer uploaded patch set 3 V -1 03/30/25, 08:17

  7. core-ci voted on patch set 3 V +1 03/30/25, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76662

  8. Benni Mack updated the commit message in patch set 4 V +1 04/05/25, 07:42

  9. core-ci voted on patch set 4 V +1 04/05/25, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77033

  10. Benni Mack commented on patch set 4 CR +1 V +1 04/08/25, 09:09

    Very nice improvement, checked this via Blackfire
  11. Christian Kuhn voted on patch set 4 CR +1 V +1 04/08/25, 09:12

  12. Benni Mack voted on patch set 4 CR +2 V +2 04/08/25, 09:13

  13. Benni Mack merged patch set 5 04/08/25, 09:22