Review main Merged

87878[TASK] Add additional `EXT:redirects` functional tests

Stefan Bürk CR +2 V +2 Normal +237 −0 updated 01/27/25, 12:34

Commit message

This change adds additional `RedirectService` functional
tests for `EXT:redirects` to cover some cases which has
been meanwhile fixed, but are still open in TYPO3 v12,
described in #99797.

Some test datasets are disabled in TYPO3 v12 and will be
enabled again with a following bugfix change for #99797.

One data set regarding cross site root redirect shows a
behaviour with a behaviour which needs to be decided if
that behaviour is correct. Added comments for that and
not in scope of this change to discuss or fix.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Torben Hansen +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Torben Hansen +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1216

  1. Stefan Bürk uploaded patch set 1 01/24/25, 15:38

  2. core-ci voted on patch set 1 V +1 01/24/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72979

  3. Stefan Bürk uploaded patch set 2 V +1 01/24/25, 16:41

  4. Stefan Bürk updated the commit message in patch set 3 01/24/25, 16:43

  5. core-ci voted on patch set 2 V -1 01/24/25, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72980

  6. core-ci voted on patch set 3 V -1 01/24/25, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72981

  7. Stefan Bürk uploaded patch set 4 V -1 01/24/25, 16:58

  8. core-ci voted on patch set 4 V +1 01/24/25, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72982

  9. Stefan Bürk commented on patch set 4 01/24/25, 17:17

    Already pushed backports, mainly due to the required modifications for 12.4 (should be also reviewed).
  10. Garvin Hicking voted on patch set 4 CR +1 V +1 01/24/25, 21:19

  11. Torben Hansen voted on patch set 4 CR +1 V +1 01/25/25, 08:48

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 01/26/25, 11:29

  13. Georg Ringer voted on patch set 4 CR +1 V +1 01/26/25, 21:11

  14. Stefan Bürk voted on patch set 4 CR +2 V +2 01/27/25, 06:57

  15. Stefan Bürk merged patch set 5 01/27/25, 06:57

  16. Christian Kuhn commented on patch set 5 01/27/25, 12:34

    RedirectServiceTest.php:85 Unresolved

    iirc default functional test teardown do this already?