87878[TASK] Add additional `EXT:redirects` functional tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
- Torben Hansen +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
- Torben Hansen +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 3
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectService_targetPageInDifferentSiteRootWithTranslations.csvnew+14 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectService_targetPageInSameSiteRootWithTranslations.csvnew+17 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php1+206 −0
Review log 1216
-
Stefan Bürk uploaded patch set 1 01/24/25, 15:38
-
core-ci voted on patch set 1 V +1 01/24/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72979
-
Stefan Bürk uploaded patch set 2
V +101/24/25, 16:41 -
Stefan Bürk updated the commit message in patch set 3 01/24/25, 16:43
-
core-ci voted on patch set 2 V -1 01/24/25, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72980
-
core-ci voted on patch set 3 V -1 01/24/25, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72981
-
Stefan Bürk uploaded patch set 4
V -101/24/25, 16:58 -
core-ci voted on patch set 4 V +1 01/24/25, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72982
-
Stefan Bürk commented on patch set 4 01/24/25, 17:17
Already pushed backports, mainly due to the required modifications for 12.4 (should be also reviewed). -
Garvin Hicking voted on patch set 4 CR +1 V +1 01/24/25, 21:19
-
Torben Hansen voted on patch set 4 CR +1 V +1 01/25/25, 08:48
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 01/26/25, 11:29
-
Georg Ringer voted on patch set 4 CR +1 V +1 01/26/25, 21:11
-
Stefan Bürk voted on patch set 4 CR +2 V +2 01/27/25, 06:57
-
Stefan Bürk merged patch set 5 01/27/25, 06:57
-
Christian Kuhn commented on patch set 5 01/27/25, 12:34
RedirectServiceTest.php:85Unresolvediirc default functional test teardown do this already?