Review 12.4 Merged

87880[TASK] Add additional `EXT:redirects` functional tests

Stefan Bürk CR +2 V +2 Normal +236 −0 updated 01/27/25, 06:58

Commit message

This change adds additional `RedirectService` functional
tests for `EXT:redirects` to cover some cases which has
been meanwhile fixed, but are still open in TYPO3 v12,
described in #99797.

Some test datasets are disabled in TYPO3 v12 and will be
enabled again with a following bugfix change for #99797.

One data set regarding cross site root redirect shows a
behaviour with a behaviour which needs to be decided if
that behaviour is correct. Added comments for that and
not in scope of this change to discuss or fix.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 56

  1. Stefan Bürk uploaded patch set 1 01/24/25, 17:16

  2. core-ci voted on patch set 1 V +1 01/24/25, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72984

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 01/24/25, 21:19

  4. Torben Hansen voted on patch set 1 CR +1 V +1 01/25/25, 08:48

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 01/27/25, 06:58

  6. Stefan Bürk merged patch set 2 01/27/25, 06:58