87885[BUGFIX] Prevent CSP module showing link when EXT:lowlevel is missing
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1315
-
Garvin Hicking uploaded patch set 1 01/26/25, 11:05
-
core-ci voted on patch set 1 V +1 01/26/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73020
-
Andreas Kienast commented on patch set 1 CR -1 01/27/25, 08:29
-
Garvin Hicking commented on patch set 1 01/27/25, 08:49
content-security-policy.xlf:23ReplyHm, not sure I understand. Do you have a specific alternate wording suggestion? Or do you mean to remove the message altogether? IMO there should be a message that hints people at "hey, install ext:lowlevel to see a cool list of csp mutations". But if removing the message for people without that extension finds more consent, I can live with removing it. We just need to "unbreak" the currenr situation somehow. -
Andreas Kienast commented on patch set 1 01/27/25, 12:39
content-security-policy.xlf:23ReplyIt's not about removing the message, but about making it explicit EXT:lowlevel **needs** to be installed. Example: ``` A list of the existing Content Security Policy Mutations can be viewed in the %s module. Please install EXT:lowlevel to do so. ``` -
Garvin Hicking commented on patch set 1 01/27/25, 13:18
content-security-policy.xlf:23ReplyI see, however I find this variant probably sounds like EXT:lowevel SHOULD be installed, while this is more a COULD. How about: ``` If you install the core EXT:lowlevel extension, you can can see a list of the existing Content Security Policy Mutations in the %s module. ``` This would first state that EXT:lowlevel is missing, and then what you optionally could get if you install it, and still making it optional, and still keeping a hint at it...? -
Christian Kuhn uploaded patch set 2
CR -1V +101/28/25, 15:01 -
Christian Kuhn commented on patch set 1 01/28/25, 15:01
content-security-policy.xlf:23Replysounds good to me, pushed. Andy? -
Christian Kuhn voted on patch set 2 CR +1 V +1 01/28/25, 15:05
-
Christian Kuhn commented on patch set 2 01/28/25, 15:06
fine with me, let's see if andy is happy, too. -
core-ci voted on patch set 2 V +1 01/28/25, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73103
-
Andreas Kienast voted on patch set 2 CR +1 V +1 01/28/25, 15:40
-
Andreas Kienast commented on patch set 2 01/28/25, 15:41
content-security-policy.xlf:23ReplyFine for me. Thanks for handling this. -
Garvin Hicking voted on patch set 2 CR +2 V +2 01/29/25, 22:15
-
Garvin Hicking merged patch set 3 01/29/25, 22:15
content-security-policy.xlf:23