87887[BUGFIX] Improve Context Menu Accessibility
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 14
- Build/Sources/Sass/component/_contextmenu.scss+12 −0
- Build/Sources/TypeScript/backend/context-menu.ts6+577 −439
- Build/Sources/TypeScript/core/lit-helper.ts+18 −1
- typo3/sysext/backend/Classes/ContextMenu/ContextMenu.php+4 −0
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu.js+38 −1
- typo3/sysext/core/Resources/Public/JavaScript/lit-helper.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+2 −1
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/AbstractCest.php+3 −4
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ExportCest.php+9 −2
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ImportCest.php+8 −2
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+13 −5
- typo3/sysext/core/Tests/Acceptance/Application/PageTree/PageTreeFilterCest.php+2 −2
Review log 3354
Show 1629 earlier messages
-
Benjamin Kott uploaded patch set 1 01/27/25, 09:49
-
core-ci voted on patch set 1 V +1 01/27/25, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73050
-
Benjamin Kott uploaded patch set 2
V +101/28/25, 15:10 -
core-ci voted on patch set 2 V +1 01/28/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73104
-
Benjamin Kott uploaded patch set 3
V +101/29/25, 09:23 -
core-ci voted on patch set 3 V +1 01/29/25, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73130
-
Benjamin Kott uploaded patch set 4
V +101/29/25, 14:21 -
core-ci voted on patch set 4 V -1 01/29/25, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73140
-
Benjamin Kott uploaded patch set 5
V -101/29/25, 15:38 -
core-ci voted on patch set 5 V -1 01/29/25, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73144
-
Benjamin Kott uploaded patch set 6
V -101/29/25, 15:56 -
core-ci voted on patch set 6 V -1 01/29/25, 16:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73146
-
Benjamin Kott uploaded patch set 7
V -101/31/25, 09:35 -
core-ci voted on patch set 7 V -1 01/31/25, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73250
-
Benjamin Kott uploaded patch set 8
V -101/31/25, 15:07 -
core-ci voted on patch set 8 V -1 01/31/25, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73276
-
Benjamin Kott uploaded patch set 9
V -101/31/25, 15:17 -
core-ci voted on patch set 9 V -1 01/31/25, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73277
-
Benjamin Kott uploaded patch set 10
V -102/03/25, 09:39 -
core-ci voted on patch set 10 V -1 02/03/25, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73370
-
Benjamin Kott uploaded patch set 11
V -102/03/25, 10:48 -
core-ci voted on patch set 11 V -1 02/03/25, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73373
-
Benjamin Kott uploaded patch set 12
V -102/03/25, 11:05 -
core-ci voted on patch set 12 V +1 02/03/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73380
-
Benjamin Kott uploaded patch set 13
V +102/03/25, 13:30 -
core-ci voted on patch set 13 V +1 02/03/25, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73404
-
Andreas Kienast commented on patch set 13 CR -1 02/04/25, 09:24
on it -
Andreas Kienast uploaded patch set 14
CR -1V +102/04/25, 09:27 -
Andreas Kienast commented on patch set 14 V -1 02/04/25, 09:28
The context menu may show outdated information: Scenario: * Open record list * Open context menu in page tree, wait for rendering * Open context menu in record list For a blink, the previous context menu state is rendered. This may cause issues in case the backend user has a slow connection and loading the new context menu needs some time.
-
core-ci voted on patch set 14 V +1 02/04/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73474
-
Benjamin Franzke uploaded patch set 15
V +102/04/25, 11:25 -
Benjamin Franzke commented on patch set 15 02/04/25, 11:25
Reply
Should be fixed with patchset 15 -
core-ci voted on patch set 15 V +1 02/04/25, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73485
-
Andreas Kienast commented on patch set 15 V +1 02/04/25, 11:59
context-menu.ts:178Could be `response !== undefined`. However, this should be checked before calling `resolve()`.context-menu.ts:237Why? I assume for "fast enough" connections to avoid "flickering"? -
Benjamin Franzke uploaded patch set 16
V +102/04/25, 14:00 -
Benjamin Franzke commented on patch set 16 02/04/25, 14:00
Reply
Donecontext-menu.ts:178ReplyActually this does not need to be checked at all, also the `Object.keys(response).length` is superfluous, as it checks for the properties on the `AjaxResponse` object, which have always a positive length. This has been wrong before, refactored now.context-menu.ts:237Replyack, adapted the comment. -
core-ci voted on patch set 16 V +1 02/04/25, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73495
-
Benjamin Franzke uploaded patch set 17
V +102/04/25, 14:29 -
Andreas Kienast commented on patch set 17 02/04/25, 14:35
context-menu.ts:386left-over or wip? -
core-ci voted on patch set 17 V +1 02/04/25, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73501
-
Benjamin Franzke uploaded patch set 18
V +102/04/25, 14:48 -
Benjamin Franzke commented on patch set 18 CR +1 V +1 02/04/25, 14:48
context-menu.ts:386Replyleft-over, sorry -
core-ci voted on patch set 18 V +1 02/04/25, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73504
-
Benjamin Franzke uploaded patch set 19
CR +1V +102/04/25, 15:01 -
Benjamin Franzke voted on patch set 19 V -1 02/04/25, 15:05
-
core-ci voted on patch set 19 V +1 02/04/25, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73509
-
Benjamin Franzke uploaded patch set 20
CR +1V +102/04/25, 16:14 -
core-ci voted on patch set 20 V +1 02/04/25, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73514
-
Benjamin Franzke uploaded patch set 21
V +102/04/25, 16:23 -
core-ci voted on patch set 21 V +1 02/04/25, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73515
-
Andreas Kienast commented on patch set 21 CR +1 V +1 02/05/25, 06:34
Room for improvement: when a context menu is open, the hover state is not applied anymore to any element outside the context menu. However, clicks are passed through, which is kinda unexpected. -
Benjamin Kott commented on patch set 21 02/05/25, 07:27
Reply
Seems to be different on Mac/Windows/Linux - Windows and Linux pass the click through and it was implemented to restore that default behavior of context menus. MacOS seems to go another route here - not sure about this. But as mentioned it´s room for improvement. But can be addressed in a different patchset. -
Benjamin Kott voted on patch set 21 CR +2 V +2 02/05/25, 07:27
-
Benjamin Kott merged patch set 22 02/05/25, 07:54