Review main Merged

87892[TASK] Use first class callable closures instead of array callables

Oliver Hader CR +2 V +2 Normal +59 −35 updated 09/08/26, 18:04

Commit message

Array callables such as [$this, 'method'] are replaced with the first
class callable syntax $this->method(...), which is type safe and can
be resolved by static analysis.

The failsafe container test keeps the array notation covered as well,
since service providers may use either notation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 1726

Show 1 earlier messages
  1. Oliver Hader uploaded patch set 1 01/27/25, 17:44

  1. Oliver Hader commented on patch set 2 01/27/25, 17:45

    Published edit on patch set 1.
  2. core-ci voted on patch set 1 V -1 01/27/25, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73063

  3. core-ci voted on patch set 2 V -1 01/27/25, 17:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73064

  4. Oliver Hader uploaded patch set 3 V -1 01/27/25, 21:01

  5. core-ci voted on patch set 3 V -1 01/27/25, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73068

  6. Georg Ringer uploaded patch set 4 V -1 03/24/25, 21:02

  7. core-ci voted on patch set 4 V -1 03/24/25, 21:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76184

  8. Benjamin Franzke commented on patch set 4 07/04/25, 11:34

    FailsafeContainerTest.php:412

    We should test old and new case here.
  9. Benni Mack uploaded patch set 5 V -1 09/02/26, 16:48

  10. Benni Mack commented on patch set 5 09/02/26, 16:50

    This change is ready for review.

    FailsafeContainerTest.php:412 Reply

    Done
  11. Benni Mack updated the commit message in patch set 6 09/02/26, 16:50

  12. core-ci voted on patch set 5 V +1 09/02/26, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107658

  13. Wouter Wolters commented on patch set 6 CR -1 09/02/26, 17:01

    on it
  14. core-ci voted on patch set 6 V +1 09/02/26, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107661

  15. Wouter Wolters uploaded patch set 7 CR -1 V +1 09/02/26, 17:17

  16. Wouter Wolters uploaded patch set 8 09/02/26, 17:27

  17. core-ci voted on patch set 7 V -1 09/02/26, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107665

  18. core-ci voted on patch set 8 V -1 09/02/26, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107666

  19. Wouter Wolters uploaded patch set 9 V -1 09/02/26, 17:53

  20. core-ci voted on patch set 9 V +1 09/02/26, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107668

  21. Wouter Wolters voted on patch set 9 CR +1 V +1 09/02/26, 18:01

  22. Simon Schaufelberger voted on patch set 9 CR +1 V +1 09/02/26, 18:33

  23. Oliver Klee voted on patch set 9 CR +1 V +1 09/02/26, 19:04

  24. Benni Mack voted on patch set 9 CR +2 V +2 09/08/26, 18:04

  25. Benni Mack merged patch set 10 09/08/26, 18:04