Review main Merged

87920[TASK] Have readonly stateless BootstrapRenderer

Christian Kuhn CR +2 V +2 Normal +16 −103 updated 01/28/25, 16:12

Commit message

By using DI properly, the service can be easily made stateless.
It is declared public since its instantiated using makeInstance()
by "factory" FlashMessageRendererResolver.
Simplify BootstrapRenderer and the other two implementations
a bit along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Christian Kuhn uploaded patch set 1 01/28/25, 14:39

  2. core-ci voted on patch set 1 V -1 01/28/25, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73099

  3. Christian Kuhn uploaded patch set 2 V -1 01/28/25, 14:47

  4. Christian Kuhn uploaded patch set 3 01/28/25, 14:52

  5. core-ci voted on patch set 2 V -1 01/28/25, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73101

  6. core-ci voted on patch set 3 V +1 01/28/25, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73102

  7. Benni Mack voted on patch set 3 CR +1 V +1 01/28/25, 15:21

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 01/28/25, 15:32

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 01/28/25, 16:12

  10. Christian Kuhn merged patch set 4 01/28/25, 16:12