87923[TASK] Utilize Schema API in EXT:workspaces
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/workspaces/Classes/Backend/LiveSearch/WorkspaceProvider.php+6 −2
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php+49 −37
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php8+36 −40
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php+6 −2
- typo3/sysext/workspaces/Classes/Dependency/ElementEntityProcessor.php1+4 −2
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php2+8 −5
- typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php2+10 −2
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php2+11 −5
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+10 −25
- typo3/sysext/workspaces/Classes/Service/HistoryService.php2+23 −19
- typo3/sysext/workspaces/Classes/Service/IntegrityService.php2+39 −27
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php8+87 −66
- typo3/sysext/workspaces/Tests/Functional/EventListener/PageTreeItemsHighlighterTest.php+1 −1
- typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php+10 −9
- typo3/sysext/workspaces/Tests/Unit/Controller/Remote/RemoteServerTest.php+6 −2
Review log 2332
Show 47 earlier messages
-
Benni Mack uploaded patch set 1 01/29/25, 07:36
-
core-ci voted on patch set 1 V -1 01/29/25, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73126
-
Benni Mack uploaded patch set 2
V -101/29/25, 07:51 -
core-ci voted on patch set 2 V -1 01/29/25, 08:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73127
-
Benni Mack uploaded patch set 3
V -101/29/25, 08:08 -
core-ci voted on patch set 3 V -1 01/29/25, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73128
-
Benni Mack uploaded patch set 4
V -101/29/25, 08:20
-
core-ci voted on patch set 4 V +1 01/29/25, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73129
-
Benni Mack updated the commit message in patch set 5
V +101/29/25, 11:03 -
core-ci voted on patch set 5 V +1 01/29/25, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73135
-
Andreas Kienast commented on patch set 5 CR -1 01/29/25, 12:41
RemoteServer.php:125Can we declare `\stdClass $parameter` here?RemoteServer.php:232We use something similar in line 213. Can we extract the granularity declaration outside this huge if/else block? Alternatively, assign a variable here and do the `this->diffUtility->diff()` call only once.StageChangeNotification.php:79Why is it now necessary to check whether a schema exists for a table? If it's for the sake of being safe, I suggest to check this at the very beginning of the method.HistoryService.php:123`!$fieldInformation->isType(TableColumnType::PASSTHROUGH)`WorkspaceService.php:265Isn't this argument obsolete with the presence of `$schema` (`$schema->getName()`)?WorkspaceService.php:266same hereWorkspaceService.php:274same hereWorkspaceService.php:291`$schema->getCapability(TcaSchemaCapability::RestrictionRootLevel)...` -
Benni Mack uploaded patch set 6
CR -1V +101/29/25, 14:42 -
core-ci voted on patch set 6 V +1 01/29/25, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73142
-
Benni Mack commented on patch set 6 01/29/25, 15:38
RemoteServer.php:97ReplyDoneRemoteServer.php:125ReplyDoneRemoteServer.php:232ReplyDoneStageChangeNotification.php:79ReplyDoneHistoryService.php:123ReplyDoneWorkspaceService.php:265ReplyDoneWorkspaceService.php:266ReplyDoneWorkspaceService.php:274ReplyDoneWorkspaceService.php:291ReplyDone -
Andreas Kienast voted on patch set 6 CR +1 01/29/25, 15:59
-
Christian Kuhn commented on patch set 6 01/29/25, 17:15
hmmm. *maybe* it would be great to push a series of pre-patches to make more services stateless. this shouldn't be *that* to hard since ext:workspaces in essentially fully `@internal` and should not be *that* time consuming, eithre. this would rule out a source of issues in this area. what do you think? i think we could come up with some pre-patches quite quickly.RemoteServer.php:76note HistoryService is indirectly stateful since its dependency RecordHistory *is* stateful. I think this was the reason we went with makeInstance() instead of injection for now.ElementEntityProcessor.php:37note to self: these properties should die, especially DH must never be re-used.BackendUtilityHook.php:37needs test. i'd expect this class needs to be set public.PreviewUriBuilder.php:53looks as if we should inject cache.runtime and park both previewlinklifetime and pageCache in there after first use.IntegrityService.php:31another service we should rather make stateless to then get it injected and to not have public then: it looks as if both $issues as well as $affectedElements should be hand around instead between service and consumer, and $statusRepresentation should be constant. -
Christian Kuhn commented on patch set 6 01/29/25, 19:01
-
Christian Kuhn commented on patch set 6 01/29/25, 21:29
BackendUtilityHook.php:37Replyscratch that: this is an event listeners, and core configures those as public. -
Christian Kuhn commented on patch set 6 01/29/25, 21:46
-
Christian Kuhn commented on patch set 6 01/30/25, 02:18
-
Christian Kuhn uploaded patch set 7
CR +1V +101/30/25, 19:40 -
Christian Kuhn commented on patch set 6 01/30/25, 19:41
RemoteServer.php:76Replynot great but not terrible in this case. still, we should fix that service, stumbled upon it multiple times now.PreviewUriBuilder.php:53ReplyDoneIntegrityService.php:31ReplyDone -
Christian Kuhn commented on patch set 7 01/30/25, 19:41
Reply
Done -
core-ci voted on patch set 7 V -1 01/30/25, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73209
-
Christian Kuhn uploaded patch set 8
V -101/30/25, 19:56 -
core-ci voted on patch set 8 V +1 01/30/25, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73211
-
Christian Kuhn updated the commit message in patch set 9
V +101/30/25, 20:03 -
Christian Kuhn voted on patch set 9 CR +1 V +1 01/30/25, 20:03
-
core-ci voted on patch set 9 V +1 01/30/25, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73212
-
Andreas Kienast voted on patch set 9 CR +1 V +1 01/31/25, 13:17
-
Benni Mack voted on patch set 9 CR +2 V +2 01/31/25, 13:26
-
Benni Mack merged patch set 10 01/31/25, 13:26
RemoteServer.php:97