Review main Merged

87924[TASK] Test transparent image processing with avif and webp

André Buchmann CR +2 V +2 Normal +70 −0 updated 01/31/25, 15:56

Commit message

The image formats avif and webp support transparency. For both
formats new tests are added to the image processing tests in the
install tool. They convert a png with transparency to avif/webp
to confirm the correct output.

As of today ddev v1.24.2 web-images are debian bookworm based and
ship with ImageMagick 6.9.11-60 Q16. This version is known to
produce black backgrounds with avif. ImageMagick 7 renders the
transparency correctly.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. André Buchmann uploaded patch set 1 01/29/25, 09:32

  2. core-ci voted on patch set 1 V +1 01/29/25, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73131

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 01/30/25, 22:42

    Yes, this is great! Thank you!
  4. Benni Mack voted on patch set 1 CR +1 V +1 01/31/25, 14:50

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 01/31/25, 14:53

  6. Garvin Hicking merged patch set 2 01/31/25, 15:56