Review main Merged

87925[TASK] Prepare recycler code for Schema API

Benni Mack CR +2 V +2 Hard +207 −294 updated 02/07/25, 11:10

Commit message

This change removes the unnecessary RecyclerUtility
and prepares for the introduction of the Schema API
in EXT:recycler.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2127

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 01/29/25, 10:09

  2. core-ci voted on patch set 1 V -1 01/29/25, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73132

  1. Benni Mack uploaded patch set 2 V -1 01/29/25, 11:10

  2. core-ci voted on patch set 2 V -1 01/29/25, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73136

  3. Benni Mack uploaded patch set 3 V -1 01/29/25, 11:21

  4. core-ci voted on patch set 3 V -1 01/29/25, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73137

  5. Benni Mack uploaded patch set 4 V -1 01/29/25, 11:39

  6. core-ci voted on patch set 4 V +1 01/29/25, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73139

  7. Andreas Kienast commented on patch set 4 01/29/25, 14:07

    RecyclerAjaxController.php:171

    `$schema` is unused here
  8. Benni Mack uploaded patch set 5 V +1 01/29/25, 14:52

  9. Benni Mack commented on patch set 5 01/29/25, 14:52

    RecyclerAjaxController.php:171 Reply

    Done
  10. core-ci voted on patch set 5 V +1 01/29/25, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73143

  11. Christian Kuhn voted on patch set 5 CR +1 01/29/25, 17:21

  12. Georg Ringer commented on patch set 5 01/29/25, 20:40

    RecyclerAjaxController.php:414

    should that be diffed with $GLOBALS['TCA'], got edge cases where tables_modify contained tables which have been removed in the meantime
  13. Christian Kuhn commented on patch set 5 01/30/25, 16:56

    RecyclerAjaxController.php:414 Reply

    you mean $this->getBackendUser()->groupData['tables_modify'] may contain stalled data and can have entries of tables that don't exist in $GLOBALS['TCA'] anymore?
  14. Andreas Kienast commented on patch set 5 01/31/25, 13:35

    RecyclerAjaxController.php:414 Reply

    This sounds like a general issue and must not get "fixed" at this particular place.
  15. Stefan Bürk commented on patch set 5 01/31/25, 20:46

    RecyclerAjaxController.php:414 Reply

    I'd say that should better handled in the backend user authentication / group resolver thingy when reading (dropping no longer existing tables in TCA) directly, instead of fixing that eventually in multiple places.
  16. Andreas Kienast voted on patch set 5 CR +1 V +1 02/06/25, 19:22

  17. Oli Bartsch commented on patch set 5 02/06/25, 20:56

    RecyclerAjaxController.php:399

    What do I miss, why do we access $GLOBALS['TCA'] here when having schema factory already injected?
  18. Benni Mack commented on patch set 5 02/06/25, 21:17

    RecyclerAjaxController.php:399 Reply

    This patch prepares for using Schema API, because I wanted to have this in smaller steps.

    RecyclerAjaxController.php:414 Reply

    OK. will change that with the next patch set
  19. Benni Mack uploaded patch set 6 CR +1 V +1 02/07/25, 10:38

  20. Benni Mack commented on patch set 6 02/07/25, 10:39

    RecyclerAjaxController.php:414 Reply

    Done
  21. core-ci voted on patch set 6 V +1 02/07/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73707

  22. Christian Kuhn voted on patch set 6 CR +1 V +1 02/07/25, 10:55

  23. Oli Bartsch commented on patch set 6 CR +1 V +1 02/07/25, 10:58

    RecyclerAjaxController.php:399 Reply

    Acknowledged
  24. Benni Mack voted on patch set 6 CR +2 V +2 02/07/25, 11:10

  25. Benni Mack merged patch set 7 02/07/25, 11:10