87925[TASK] Prepare recycler code for Schema API
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 7
- Build/phpstan/phpstan-baseline.neon+0 −12
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php11+50 −8
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+5 −13
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+142 −88
- typo3/sysext/recycler/Classes/Task/CleanerFieldProvider.php+5 −11
- typo3/sysext/recycler/Classes/Task/CleanerTask.php+5 −9
- typo3/sysext/recycler/Classes/Utility/RecyclerUtility.phpdeleted+0 −153
Review log 2127
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 01/29/25, 10:09
-
core-ci voted on patch set 1 V -1 01/29/25, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73132
-
Benni Mack uploaded patch set 2
V -101/29/25, 11:10 -
core-ci voted on patch set 2 V -1 01/29/25, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73136
-
Benni Mack uploaded patch set 3
V -101/29/25, 11:21 -
core-ci voted on patch set 3 V -1 01/29/25, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73137
-
Benni Mack uploaded patch set 4
V -101/29/25, 11:39 -
core-ci voted on patch set 4 V +1 01/29/25, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73139
-
Andreas Kienast commented on patch set 4 01/29/25, 14:07
-
Benni Mack uploaded patch set 5
V +101/29/25, 14:52 -
Benni Mack commented on patch set 5 01/29/25, 14:52
RecyclerAjaxController.php:171ReplyDone -
core-ci voted on patch set 5 V +1 01/29/25, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73143
-
Christian Kuhn voted on patch set 5 CR +1 01/29/25, 17:21
-
Georg Ringer commented on patch set 5 01/29/25, 20:40
RecyclerAjaxController.php:414should that be diffed with $GLOBALS['TCA'], got edge cases where tables_modify contained tables which have been removed in the meantime -
Christian Kuhn commented on patch set 5 01/30/25, 16:56
RecyclerAjaxController.php:414Replyyou mean $this->getBackendUser()->groupData['tables_modify'] may contain stalled data and can have entries of tables that don't exist in $GLOBALS['TCA'] anymore? -
Andreas Kienast commented on patch set 5 01/31/25, 13:35
RecyclerAjaxController.php:414ReplyThis sounds like a general issue and must not get "fixed" at this particular place. -
Stefan Bürk commented on patch set 5 01/31/25, 20:46
RecyclerAjaxController.php:414ReplyI'd say that should better handled in the backend user authentication / group resolver thingy when reading (dropping no longer existing tables in TCA) directly, instead of fixing that eventually in multiple places. -
Andreas Kienast voted on patch set 5 CR +1 V +1 02/06/25, 19:22
-
Oli Bartsch commented on patch set 5 02/06/25, 20:56
RecyclerAjaxController.php:399What do I miss, why do we access $GLOBALS['TCA'] here when having schema factory already injected? -
Benni Mack commented on patch set 5 02/06/25, 21:17
RecyclerAjaxController.php:399ReplyThis patch prepares for using Schema API, because I wanted to have this in smaller steps.RecyclerAjaxController.php:414ReplyOK. will change that with the next patch set -
Benni Mack uploaded patch set 6
CR +1V +102/07/25, 10:38 -
Benni Mack commented on patch set 6 02/07/25, 10:39
RecyclerAjaxController.php:414ReplyDone -
core-ci voted on patch set 6 V +1 02/07/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73707
-
Christian Kuhn voted on patch set 6 CR +1 V +1 02/07/25, 10:55
-
Oli Bartsch commented on patch set 6 CR +1 V +1 02/07/25, 10:58
RecyclerAjaxController.php:399ReplyAcknowledged -
Benni Mack voted on patch set 6 CR +2 V +2 02/07/25, 11:10
-
Benni Mack merged patch set 7 02/07/25, 11:10
RecyclerAjaxController.php:171