Review main Merged

87926[BUGFIX] Use new selectItem syntax with assoc array

Benni Mack CR +2 V +2 Easy +14 −15 updated 01/30/25, 07:31

Commit message

This change adapts the itemsProcFunc for
"index_config" to use "label", "value" and "icon"
instead of the old numeric syntax for select items.

At the same time, in order to demonstrate
best practices, DI and Schema API is used.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 01/29/25, 11:34

  2. core-ci voted on patch set 1 V +1 01/29/25, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73138

  3. Andreas Kienast voted on patch set 1 CR +1 01/29/25, 11:44

  4. Christian Kuhn uploaded patch set 2 CR +1 V +1 01/29/25, 16:33

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 01/29/25, 16:33

  6. core-ci voted on patch set 2 V +1 01/29/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73149

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 01/30/25, 06:43

  8. Benni Mack voted on patch set 2 CR +2 V +2 01/30/25, 07:31

  9. Benni Mack merged patch set 3 01/30/25, 07:31